-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type providers get created hundreds of times causing large LOH allocations and UI delays inside VS #5929
Milestone
Comments
Note, I've filed #5931 to track the assembly metadata that the type providers themselves are loading. |
This was referenced Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Trace: https://developercommunity.visualstudio.com/content/problem/379653/vs-slow-typing-and-hang-1.html.
GC Rollup By Generation
In this trace, we're seeing large percentage of time spent collecting generations 1 & 2. If we dig into it, we can see that the majority of Gen2 collections are due to us creating hundreds of the same type providers over and over again, and they themselves allocating around 800KB each time. This results in about ~1.5 GB allocations all ending up on the LOH.
I would verify if we actually need to create type providers over and over again, and if not, introduce a cache based on the inputs so that we avoid this.
The text was updated successfully, but these errors were encountered: