P2p references #3777
Merged
P2p references #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
reviewed
Oct 23, 2017
src/fsharp/vs/service.fs
Outdated
| @@ -1374,8 +1374,8 @@ type FSharpParsingOptions = | |||
| } | |||
|
|
|||
| member x.LastFileName = | |||
| Debug.Assert(not (Array.isEmpty x.SourceFiles), "Parsing options don't contain any file") | |||
There was a problem hiding this comment.
This isn't necessary anymore because of #3793.
brettfo
approved these changes
Oct 24, 2017
| | Some (:? Workspace as workspace) -> | ||
| let solution = workspace.CurrentSolution | ||
| let documentIds = solution.GetDocumentIdsWithFilePath(fileName) | ||
| if not documentIds.IsEmpty then |
There was a problem hiding this comment.
Is this if statement necessary given that below you check documentIdsFiltered.Length? Or does Seq.toArray throw on an empty sequence?
There was a problem hiding this comment.
it is as you say unnecessary
| if not documentIds.IsEmpty then | ||
| let documentIdsFiltered = documentIds |> Seq.filter workspace.IsDocumentOpen |> Seq.toArray | ||
| for documentId in documentIdsFiltered do | ||
| Trace.TraceInformation("{0:n3} Requesting Roslyn reanalysis of {1}", DateTime.Now.TimeOfDay.TotalSeconds, documentId) |
There was a problem hiding this comment.
Why not just a regular timestamp?
There was a problem hiding this comment.
@brettfo this line came from:
https://github.com/Microsoft/visualfsharp/pull/3777/files/93ebd231f81eb6de79fa42a48cebd268e4831e54#diff-cdf0a4fbb7615b8029d78133924259c3L73
just indented deeper.
KevinRansom
added a commit
that referenced
this pull request
Oct 24, 2017
* P2p references * Fix test * test fix * go faster stripes * new project works better * Re-add debug assert for sourcefiles
This was referenced Oct 25, 2017
KevinRansom
pushed a commit
that referenced
this pull request
Oct 26, 2017
* don't update project info if the source file collection is empty (#3792) * install templates VSIX to a unique directory (#3804) * P2p references (#3777) * P2p references * Fix test * test fix * go faster stripes * new project works better * Re-add debug assert for sourcefiles * Parameterise rc location (#3744) * Fix issues
KevinRansom
added a commit
that referenced
this pull request
Oct 27, 2017
* Merge dev15.5 to dev15.6 (#3825) * don't update project info if the source file collection is empty (#3792) * install templates VSIX to a unique directory (#3804) * P2p references (#3777) * P2p references * Fix test * test fix * go faster stripes * new project works better * Re-add debug assert for sourcefiles * Parameterise rc location (#3744) * Fix issues * Merge master to dev15.6 (#3826) * Put nupkgs into artifacts (#3806) * Make FCS build work on Jenkins (#3788)
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* P2p references * Fix test * test fix * go faster stripes * new project works better * Re-add debug assert for sourcefiles
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* P2p references * Fix test * test fix * go faster stripes * new project works better * Re-add debug assert for sourcefiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.