Optimization: Generic specialization for equality

.gitignore

@@ -1,15 +1,14 @@
 lib/debug
 lib/release
 lib/proto
-lib/bootstrap/4.0/*.mdb
-lib/bootstrap/4.0/*.xml
-lib/bootstrap/4.0/fsharpc
-lib/bootstrap/4.0/fsharpi
-lib/bootstrap/4.0/policy*
+lib/bootstrap/4.1/*.mdb
+lib/bootstrap/4.1/*.xml
+lib/bootstrap/4.1/fsharpc
+lib/bootstrap/4.1/fsharpi
+lib/bootstrap/4.1/policy*
 aclocal.m4
 src/*.userprefs
 src/fsharp/FSStrings.resources
-lkg
 packages
 src/fsharp/FSharp.Build/*.resx
 src/fsharp/FSharp.Build-proto/*.resx
@@ -66,40 +65,33 @@ tests/projects/Sample_VS2012_FSharp_ConsoleApp_net45_with_resource/Sample_VS2012
 obj
 extras
 ossreadme*.txt
-tests/fsharp/typecheck/sigs/*.exe
-tests/fsharp/typecheck/sigs/*.diff
-tests/fsharp/typecheck/sigs/*.err
-tests/fsharp/typecheck/sigs/*.vsdiff
-tests/fsharp/typecheck/sigs/*.dll
-tests/fsharp/typecheck/sigs/*.vserr
 src/fsharp/FSharp.LanguageService.Compiler/illex.*
 src/fsharp/FSharp.LanguageService.Compiler/ilpars.*
 src/fsharp/FSharp.LanguageService.Compiler/lex.*
 src/fsharp/FSharp.LanguageService.Compiler/pars.*
 src/fsharp/FSharp.LanguageService.Compiler/pplex.fs
 src/fsharp/FSharp.LanguageService.Compiler/pppars.fs
 src/fsharp/FSharp.LanguageService.Compiler/pppars.fsi
-tests/fsharp/typecheck/sigs/*.dll
-tests/fsharp/typecheck/sigs/*.exe
-tests/fsharp/typeProviders/builtin/SqlDataConnection/DataDirectory/
-tests/fsharp/typeProviders/builtin/SqlDataConnection/ExampleResolutionFolder/
-tests/fsharp/typeProviders/builtin/SqlEntityConnection/DataDirectory/
 vsintegration/src/unittests/Unittests.fsi
+tests/*FSharp_Failures.env
+tests/*FSharp_Failures.lst
 tests/fsharpqa/Source/CodeGen/EmittedIL/StaticInit/StaticInit_Module01.dll
 tests/fsharpqa/Source/CodeGen/EmittedIL/StaticInit/StaticInit_Module01.pdb
-tests/fsharp/typeProviders/helloWorld/bincompat1/
-tests/fsharp/typeProviders/helloWorld/bincompat2/
 tests/XFSharpQA_Failures.log.*
 vsintegration/src/vs/FsPkgs/FSharp.Project/FS/FSharp.ProjectSystem.FSharp.fsi
 vsintegration/src/vs/FsPkgs/FSharp.Project/FS/ctofiles/
 tests/fsharpqa/Source/CodeGen/EmittedIL/QueryExpressionStepping/Utils.dll
 tests/fsharpqa/Source/CodeGen/EmittedIL/ComputationExpressions/ComputationExprLibrary.dll
-
+tests/fsharpqa/Source/*FSharpQA_Failures.env
+tests/fsharpqa/Source/*FSharpQA_Failures.lst
 *.csproj.user
-
+*.sln.DotSettings.user
 *.ide
 *.log
 *.jrs
 *.chk
 *.bak
 *.orig
+*.mdf
+*.ldf
+tests/**/FSharp.Core.dll

.nuget/NuGet.Config

@@ -3,4 +3,10 @@
   <solution>
     <add key="disableSourceControlIntegration" value="true" />
   </solution>
+  <packageSources>  
+    <add key="myget.org dotnet-corefx" value="https://www.myget.org/F/dotnet-corefx/" />  
+    <add key="myget.org dotnet-buildtools" value="https://www.myget.org/F/dotnet-buildtools/" />  
+    <add key="myget.org fsharp-daily" value="https://www.myget.org/F/fsharp-daily/" />  
+    <add key="nuget.org" value="https://www.nuget.org/api/v2/" />  
+  </packageSources>  
 </configuration>

CHANGELOG.md

@@ -1,5 +1,5 @@
 
-    Copyright (c) Microsoft Open Technologies, Inc.  All Rights Reserved.  
+    Copyright (c) Microsoft Corporation.  All Rights Reserved.  
 
     Licensed under the Apache License, Version 2.0.  
     See License.txt in the project root for license information.
@@ -9,6 +9,28 @@ Visual F<span>#</span>
 
 All notable changes to this project will be documented in this file.
 
+### [4.0.0] - Visual Studio 2015 Update 1 - 30 November 2015
+
+#### Enhancements
+* Perf: `for i in expr do body` optimization [#219](https://github.com/Microsoft/visualfsharp/pull/219)
+* Remove type provider security dialog and use custom icon for type provider assembly reference [#448](https://github.com/Microsoft/visualfsharp/pull/448)
+* Perf: Enable parallel build inside Visual Studio [#487](https://github.com/Microsoft/visualfsharp/pull/487)
+* Perf: Remove StructBox for Value Types [#549](https://github.com/Microsoft/visualfsharp/pull/549)
+* Add compiler warnings for redundant arguments in raise/failwith/failwithf/nullArg/invalidOp/invalidArg [#630](https://github.com/Microsoft/visualfsharp/pull/630)
+* Add a compiler warning for lower case literals in patterns [#666](https://github.com/Microsoft/visualfsharp/pull/666)
+
+#### Bug fixes
+* Fix scope of types for named values in attributes improperly set [#437](https://github.com/Microsoft/visualfsharp/pull/437)
+* Add general check for escaping typars to check phase [#442](https://github.com/Microsoft/visualfsharp/pull/442)
+* Fix AccessViolationException on obfuscated assemblies [#519](https://github.com/Microsoft/visualfsharp/pull/519)
+* Fix memory leaks while reloading solutions in Visual Studio [#591](https://github.com/Microsoft/visualfsharp/pull/591)
+* Enable breakpoints in `with` augmentations for class types [#608](https://github.com/Microsoft/visualfsharp/pull/608)
+* Fix false escaping type parameter check error [#613](https://github.com/Microsoft/visualfsharp/pull/613)
+* Fix quotation of readonly fields [#622](https://github.com/Microsoft/visualfsharp/pull/622)
+* Keep the reference icons when opening references [#623](https://github.com/Microsoft/visualfsharp/pull/623)
+* Don't suppress missing FSI transitive references [#626](https://github.com/Microsoft/visualfsharp/pull/626)
+* Make Seq.cast's non-generic and generic IEnumerable implementations equivalent [#651](https://github.com/Microsoft/visualfsharp/pull/651)
+
 ### [4.0.0] - 20 July 2015
 
 Includes commits up to `dd8252eb8d20aaedf7b1c7576cd2a8a82d24f587`

CONTRIBUTING.md

@@ -3,14 +3,15 @@
 The Visual F# team is proud to be a contributor to F#, and urge you to join in too. F# users and the F# community are grateful for all contributions to F#.
 
 Besides this overview, we recommend ["Becoming a contributor"](http://mrange.wordpress.com/2014/12/11/becoming-an-fsharp-contributor/), a community blog post by Mårten Rånge. 
+For those contributing to the core of the F# compiler, we recommend ["The F# Compiler Technical Overview"](http://fsharp.github.io/2015/09/29/fsharp-compiler-guide.html)
 
 ###Getting Started
 
 - Install required software
 - Clone the repo
  - `git clone https://github.com/microsoft/visualfsharp.git`
-- How to build
-- How to run tests
+- How to build ([DEVGUIDE](DEVGUIDE.md))
+- How to run tests ([TESTGUIDE](TESTGUIDE.md))
 
 ###What to Contribute?
 
@@ -90,6 +91,8 @@ Performance improvement checkins have the following minimum requirements (in add
 
 - The PR must show a reliable, substantive performance improvement that justifies the complexity introduced.  For the compiler, performance improvements of ~1% are of interest.  For the core library, it will depend on the routine in question. For the Visual F# tools, reactivity of the user interface will be of more interest than raw CPU performance.
 
+- Performance improvements should not cause performance degradation in existing code.
+
 #### Mimimum Bar for Bug Fix Pull Requests
 
 Bug fix PRs have the following minimum requirements
@@ -100,6 +103,8 @@ Bug fix PRs have the following minimum requirements
 
 - Thorough test cases must be included in the PR (unless tests already exist for a failing case). PRs without matching tests will be closed with a polite request to please add the tests.  However, if you need help adding tests, please note this in the description of the change and people will guide you through where to add the tests.
 
+- Bug fix PRs should not cause performance degradation in existing code.
+
 #### Mimimum Bar for Feature Pull Requests
 
 Feature PRs have the following minimum requirements:
@@ -112,6 +117,12 @@ Feature PRs have the following minimum requirements:
 
 - For F# Language and Library features, you will be asked to submit a speclet for the feature to the [F# Language Design](https://github.com/fsharp/FSharpLangDesign/) GitHub repository of speclets.  In some cases you will only need to do this after your feature is accepted, but for more complex features you may be asked to do this during the review of the feature.  
 
+- Language feature implementations must take into account the expectations of typical users about the performance 
+  impact of using the feature.  For example, we should avoid the situation where using an optional language feature 
+  which appears benign to a typical user has a large negative performance impact on code.
+
+- Language feature implementations should not cause performance degradation in existing code.
+
 ###Language Evolution
 
 We are committed to carefully managing the evolution of the F# language.

DEVGUIDE.md

@@ -1,10 +1,17 @@
 # F# Compiler, Core Library and Visual F# Tools Open Contribution Repository
 
 This repo is where you can contribute to the F# compiler, core library and the Visual F# Tools.
+To learn what F# is and why it's interesting, go to [fsharp.org](http://fsharp.org). To get a free F# environment, go to [fsharp.org](http://fsharp.org/use/windows).
 
-To learn what F# is and why it's interesting, go to [fsharp.org](http://fsharp.org).
+**Compiler Technical Documentation**
 
-To get a free F# environment, go to [fsharp.org](http://fsharp.org/use/windows).
+The primary technical documents for the F# compiler code are
+
+* [The F# Language Specification](http://fsharp.org/specs/language-spec/)
+
+* [The F# Compiler Technical Guide](http://fsharp.github.io/2015/09/29/fsharp-compiler-guide.html) 
+  maintained by contributors to this repository.  Please read
+  and contribute to that guide.
 
 **License**
 > Contributions made to this repo are subject to terms and conditions of the Apache License, Version 2.0. A copy of the license can be found in the [License.txt](License.txt) file at the root of this distribution.
@@ -15,7 +22,7 @@ To get a free F# environment, go to [fsharp.org](http://fsharp.org/use/windows).
 ## 0.  A Shortcut to Build and Smoke Test
 
 You can build a subset of functionality (including bootstrapped compiler and library) and run a very 
-small number of 'smoke' tests using the script used by continuous integration:
+small number of 'smoke' tests using the script used by continuous integration on Windows:
 
     .\appveyor-build.cmd
 
@@ -66,7 +73,7 @@ Prior to a **Debug** test run, you need to complete **all** of these steps:
 
 [Optional] If testing the Visual Studio bits (see below) you will also need:
 
-    msbuild vsintegration\fsharp-vsintegration-build.proj
+    msbuild VisualFSharp.sln 
     msbuild vsintegration\fsharp-vsintegration-unittests-build.proj
 
 Prior to a **Release** test run, you need to do **all** of these:
@@ -91,15 +98,15 @@ Prior to a **Release** test run, you need to do **all** of these:
 
 [Optional] If testing **Release** build of the Visual F# IDE Tools (see below) you will also need:
 
-    msbuild vsintegration\fsharp-vsintegration-build.proj /p:Configuration=Release
+    msbuild VisualFSharp.sln /p:Configuration=Release
     msbuild vsintegration\fsharp-vsintegration-unittests-build.proj /p:Configuration=Release
 
-## 4. [Optional] Install the Visual F# IDE Tools and Clobber the F# 4.0 SDK on the machine
+## 4. [Optional] Install the Visual F# IDE Tools and Clobber the F# SDK on the machine
 
-**Note:** Step #3 will install a VSIX extension into Visual Studio 2015 that changes the Visual F# IDE Tools 
+**Note:** Step #2 below will install a VSIX extension into Visual Studio 2015 that changes the Visual F# IDE Tools 
 components installed into Visual Studio 2015.  You can revert this step by disabling or uninstalling the addin.
 
-**Note:** Step #4 will clobber the machine-wide installed F# 4.0 SDK on your machine. This replaces the ``fsi.exe``/``fsiAnyCpu.exe`` used 
+**Note:** Step #3 below will clobber the machine-wide installed F# SDK on your machine. This replaces the ``fsi.exe``/``fsiAnyCpu.exe`` used 
 by Visual F# Interactive and the ``fsc.exe`` used by ``Microsoft.FSharp.targets``.  Repairing Visual Studio 2015 is currently the 
 only way to revert this step.  
 
@@ -111,24 +118,29 @@ For **Debug**:
 
 1. Ensure that the VSIX package is uninstalled. In VS, select Tools/Extensions and Updates and if the package `VisualStudio.FSharp.EnableOpenSource` is installed, select Uninstall
 1. Run ``debug\net40\bin\EnableOpenSource.vsix``
-1. Run ``vsintegration\update-vsintegration.cmd debug`` (clobbers the installed F# 4.0 SDK)
+1. Run ``vsintegration\update-vsintegration.cmd debug`` (clobbers the installed F# SDK)
 
 For **Release**:
 
 1. Ensure that the VSIX package is uninstalled. In VS, select Tools/Extensions and Updates and if the package `VisualStudio.FSharp.EnableOpenSource` is installed, select Uninstall
 1. Run ``release\net40\bin\EnableOpenSource.vsix``
-1. Run ``vsintegration\update-vsintegration.cmd release`` (clobbers the installed F# 4.0 SDK)
+1. Run ``vsintegration\update-vsintegration.cmd release`` (clobbers the installed F# SDK)
 
 Restart Visual Studio, it should now be running your freshly-built Visual F# IDE Tools with updated F# Interactive. 
 
 
 ### Notes on the build
 
-1. The `update.cmd` script adds the built `FSharp.Core` to the GAC, adds required strong name validation skips, and NGens the compiler and libraries. This requires admin privileges.
+1. The `update.cmd` script adds required strong name validation skips, and NGens the compiler and libraries. This requires admin privileges.
 1. The compiler binaries produced are "private" and strong-named signed with a test key.
 1. Some additional tools are required to build the compiler, notably `fslex.exe`, `fsyacc.exe`, `FSharp.PowerPack.Build.Tasks.dll`, `FsSrGen.exe`, `FSharp.SRGen.Build.Tasks.dll`, and the other tools found in the `lkg` directory.
 1. The overall bootstrapping process executes as follows
  - We first need an existing F# compiler. We use the one in the `lkg` directory. Let's assume this compiler has an `FSharp.Core.dll` with version X.
  - We use this compiler to compile the source in this distribution, to produce a "proto" compiler, dropped to the `proto` directory. When run, this compiler still relies on `FSharp.Core.dll` with version X.
  - We use the proto compiler to compile the source for `FSharp.Core.dll` in this distribution.
  - We use the proto compiler to compile the source for `FSharp.Compiler.dll`, `fsc.exe`, `fsi.exe`, and other binaries found in this distribution.
+
+### Further technical resources
+
+The primary technical guide to the core compiler code is [The F# Compiler Technical Guide](http://fsharp.github.io/2015/09/29/fsharp-compiler-guide.html).  Please read and contribute to that guide.
+

License.txt

@@ -1,4 +1,4 @@
-Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.
+Copyright (c) Microsoft Corporation. All rights reserved.
 
 Licensed under the Apache License, Version 2.0 (the "License"); you may not use
 these files except in compliance with the License. You may obtain a copy of the