Teach fsc/fsi how to use responsefile #831

enricosada · 2015-12-23T16:49:03Z

i need feedback on how to test this.

ok in tests\fsharpqa\Source\CompilerOptions\{fsc|fsi}\responseFiles.

But a good test without do output difference?
i think i can try to generate a specific error, and check for that one ( and response file fix the error ), a good candidate?

enricosada · 2015-12-23T16:49:43Z

appveyor-build.cmd

@@ -13,7 +13,7 @@ echo Build and run a subset of test suites
 echo.
 echo Usage:
 echo.
-echo appveyor-build.cmd ^<all^|net40^|portable47^|portable7^|portable78^|portable259^|vs^|cambridge_suite^|qa_suite^|smoke^|smoke_only^>
+echo appveyor-build.cmd ^<all^|net40^|portable47^|portable7^|portable78^|portable259^|vs^|cambridge_suite^|qa_suite^|smoke^|smoke_only^|build_only^>


this add build_only argument to appveyor, to build without tests ( compile only ).
can be combined with others arguments, for example net40,portable7,build_only compile only net40 and portable7 instead of compile+tests

enricosada · 2016-01-05T17:15:48Z

ok added tests and doc ( in --help, same text of roslyn )
ready to review/merge.

dsyme · 2016-01-05T20:09:25Z

I looked over this briefly and everything looked fine to me. It would be great to have this in.

enricosada · 2016-01-07T14:35:23Z

ok, used a completely new error number, some cleanups, and added test for error if response file is missing

mmitche · 2016-01-07T17:55:40Z

@otawfik-ms Any idea what the issue is with the timeouts? Are they real failures or do the tests just take a long time? (We can up the timeouts if necessary)

OmarTawfik · 2016-01-07T18:01:19Z

@mmitche No. 120 minutes are much longer than what is expected. I'll send a PR to run the smoke tests only, until #697 is done, and I can look into existing failures.

mmitche · 2016-01-07T18:08:03Z

@otawfik-ms I can also give you direct access to a machine for debugging if necessary

enricosada · 2016-01-07T18:12:12Z

@otawfik-ms @mmitche can you can add test log to jenkins build artifacts, no ui, but we can download it if needed. Also the current fsharpqa

the net40,portable, etc

CSC : error CS0006: Metadata file 'd:\j\workspace\Microsoft_visualfsharp\net40' could not be found [d:\j\workspace\Microsoft_visualfsharp\net40,portable7,portable47,portable78,portable259,vs_prtest\vsintegration\src\unittests\Resources.MockTypeProviders\DefinitionLocationAttribute\DefinitionLocationAttribute.csproj]

is because of directory name, d:\j\workspace\Microsoft_visualfsharp\net40,portable7,portable47,portable78,portable259,vs_prtest

OmarTawfik · 2016-01-07T18:21:34Z

@enricosada you mean this?
http://dotnet-ci.cloudapp.net/job/Microsoft_visualfsharp/job/qa_suite_prtest/6/consoleFull
For test results, I've started #856 to track it.

enricosada · 2016-01-07T18:26:52Z

not the build log, i mean build artifacts. in jenkins you save file in build job, and download it later. for example compiled binaries or test results ( like https://ci.jenkins-ci.org/job/jenkins_2.0/1/ )

OmarTawfik · 2016-01-07T18:34:53Z

I'll add it in my pending changes now.

OmarTawfik · 2016-01-07T20:58:07Z

Changes are in. Both test results and build artifacts should be in Jenkins UI now.
I also restricted it to smoke tests for now. LMK if you see any more timeouts and I'll take a look.

…arguments apply )

removed the grouping by file because it's not used

smoothdeveloper · 2016-01-18T00:28:06Z

@enricosada I get a weird stack trace if I call:

fsc.exe @""


Unhandled Exception: System.ArgumentException: The path is not of a legal form.
   at System.IO.Path.NormalizePath(String path, Boolean fullCheck, Int32 maxPath
Length, Boolean expandShortPaths)
   at System.IO.Path.GetFullPathInternal(String path)
   at System.IO.Path.GetFullPath(String path)
   at Microsoft.FSharp.Compiler.AbstractIL.Internal.Library.Shim.DefaultFileSyst
em.Microsoft-FSharp-Compiler-AbstractIL-Internal-Library-Shim-IFileSystem-GetFul
lPathShim(String fileName) in C:\dev\src\projects\github.com\visualfsharp\src\ab
sil\illib.fs:line 978
   at Microsoft.FSharp.Compiler.CompileOptions.processArg@255.Invoke(FSharpList`
1 args) in C:\dev\src\projects\github.com\visualfsharp\src\fsharp\CompileOptions
.fs:line 259
   at Microsoft.FSharp.Compiler.CompileOptions.ParseCompilerOptions(FSharpFunc`2
 collectOtherArgument, FSharpList`1 blocks, FSharpList`1 args) in C:\dev\src\pro
jects\github.com\visualfsharp\src\fsharp\CompileOptions.fs:line 370
   at Microsoft.FSharp.Compiler.Driver.ProcessCommandLineFlags(TcConfigBuilder t
cConfigB, FSharpFunc`2 setProcessThreadLocals, FSharpOption`1 lcidFromCodePage,
String[] argv) in C:\dev\src\projects\github.com\visualfsharp\src\fsharp\fsc.fs:
line 261
   at Microsoft.FSharp.Compiler.Driver.GetTcImportsFromCommandLine(String[] argv
, String defaultFSharpBinariesDir, String directoryBuildingFrom, FSharpOption`1
lcidFromCodePage, FSharpFunc`2 setProcessThreadLocals, FSharpFunc`2 displayBanne
rIfNeeded, Boolean optimizeForMemory, Exiter exiter, ErrorLoggerProvider errorLo
ggerProvider, DisposablesTracker disposables) in C:\dev\src\projects\github.com\
visualfsharp\src\fsharp\fsc.fs:line 321
   at Microsoft.FSharp.Core.Operators.Raise[T](Exception exn)
   at Microsoft.FSharp.Compiler.ErrorLogger.ErrorLoggerExtensions.ReraiseIfWatso
nable(Exception exn) in C:\dev\src\projects\github.com\visualfsharp\src\fsharp\E
rrorLogger.fs:line 299
   at Microsoft.FSharp.Compiler.ErrorLogger.ErrorLoggerExtensions.ErrorLogger.Er
rorRecovery(ErrorLogger x, Exception exn, range m) in C:\dev\src\projects\github
.com\visualfsharp\src\fsharp\ErrorLogger.fs:line 322
   at Microsoft.FSharp.Compiler.Driver.GetTcImportsFromCommandLine(String[] argv
, String defaultFSharpBinariesDir, String directoryBuildingFrom, FSharpOption`1
lcidFromCodePage, FSharpFunc`2 setProcessThreadLocals, FSharpFunc`2 displayBanne
rIfNeeded, Boolean optimizeForMemory, Exiter exiter, ErrorLoggerProvider errorLo
ggerProvider, DisposablesTracker disposables) in C:\dev\src\projects\github.com\
visualfsharp\src\fsharp\fsc.fs:line 328
   at Microsoft.FSharp.Compiler.Driver.main0(String[] argv, Boolean bannerAlread
yPrinted, Exiter exiter, ErrorLoggerProvider errorLoggerProvider, DisposablesTra
cker disposables) in C:\dev\src\projects\github.com\visualfsharp\src\fsharp\fsc.
fs:line 1769
   at Microsoft.FSharp.Compiler.Driver.typecheckAndCompile(String[] argv, Boolea
n bannerAlreadyPrinted, Exiter exiter, ErrorLoggerProvider errorLoggerProvider)
in C:\dev\src\projects\github.com\visualfsharp\src\fsharp\fsc.fs:line 1977
   at Microsoft.FSharp.Compiler.Driver.mainCompile(String[] argv, Boolean banner
AlreadyPrinted, Exiter exiter) in C:\dev\src\projects\github.com\visualfsharp\sr
c\fsharp\fsc.fs:line 1989
   at Microsoft.FSharp.Compiler.CommandLineMain.Driver.main(String[] argv) in C:
\dev\src\projects\github.com\visualfsharp\src\fsharp\fscmain.fs:line 270
   at Microsoft.FSharp.Compiler.CommandLineMain.main(String[] argv) in C:\dev\sr
c\projects\github.com\visualfsharp\src\fsharp\fscmain.fs:line 285
   at Microsoft.FSharp.Core.Operators.Raise[T](Exception exn)
   at Microsoft.FSharp.Compiler.ErrorLogger.ErrorLoggerExtensions.ReraiseIfWatso
nable(Exception exn) in C:\dev\src\projects\github.com\visualfsharp\src\fsharp\E
rrorLogger.fs:line 299
   at Microsoft.FSharp.Compiler.ErrorLogger.ErrorLoggerExtensions.ErrorLogger.Er
rorRecovery(ErrorLogger x, Exception exn, range m) in C:\dev\src\projects\github
.com\visualfsharp\src\fsharp\ErrorLogger.fs:line 322
   at Microsoft.FSharp.Compiler.CommandLineMain.main(String[] argv) in C:\dev\sr
c\projects\github.com\visualfsharp\src\fsharp\fscmain.fs:line 287

It seems something special is done when the file doesn't exist (it gives a short informative error message), it would be nice if it was doing the same (maybe with another message).

For example, csc does this:

C:\dev\src\projects\github.com\visualfsharp>csc @""
Microsoft (R) Visual C# Compiler version 1.1.0.51204
Copyright (C) Microsoft Corporation. All rights reserved.

error CS2021: File name '' is empty, contains invalid characters, has a drive sp
ecification without an absolute path, or is too long
warning CS2008: No source files specified.
error CS1562: Outputs without source must have the /out option specified

enricosada · 2016-01-18T13:25:37Z

@smoothdeveloper i check if file exists, but i forgot invalid path like empty. Good catch!! thx

d:\github\fsharp>Release\net40\bin\fsc.exe "@dd"
Microsoft (R) F# Compiler version (private)
Copyright (c) Microsoft Corporation. All Rights Reserved.

error FS3192: Response file '@dd' not found in 'd:\github\fsharp\dd'

enricosada · 2016-01-18T16:44:38Z

ok, added error if empty or invalid response file name ( like @ )
ready to merge or review!

KevinRansom · 2016-01-20T05:36:51Z

merged into vs2015

Thanks for this contribution.

enricosada · 2016-01-20T09:57:14Z

@KevinRansom can you merge it in coreclr branch too? it's really useful for dotnet cli
btw why not master? the vs2015 it's the long term branch? it's not a breaking change

smoothdeveloper · 2016-01-20T09:58:47Z

@enricosada it was pulled in master too I see.

msftclas added the cla-already-signed label Dec 23, 2015

enricosada reviewed Dec 23, 2015
View reviewed changes

enricosada force-pushed the teach_fsc_how_to_use_responsefile branch from 71dc941 to 502d15b Compare January 7, 2016 14:34

enricosada added 7 commits January 8, 2016 12:03

add build_only argument at appveyor-build.cmd to skip tests ( others …

596621f

…arguments apply )

teach fsc/fsi how to use response files

f4e2cfc

add tests

6127e6a

add help about @response files

dd75644

add test compile error expected if response file does not exist

2f30b90

rename resources

9bed9be

document how to add new resources and error numbers

d43f1a9

removed the grouping by file because it's not used

enricosada force-pushed the teach_fsc_how_to_use_responsefile branch from 502d15b to d43f1a9 Compare January 8, 2016 11:03

KevinRansom added the Approved for next preview label Jan 13, 2016

use detectEncodingFromByteOrderMarks

015001d

add error if response file name is empty or invalid

20f0552

KevinRansom added the Pulling-in process label Jan 20, 2016

KevinRansom closed this Jan 20, 2016

KevinRansom reopened this Jan 20, 2016

msftclas added the cla-already-signed label Jan 20, 2016

KevinRansom merged commit 20f0552 into dotnet:master Jan 20, 2016

KevinRansom removed Approved for next preview labels Jan 20, 2016

dsyme mentioned this pull request Apr 13, 2016

add support for response file to fsc #816

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Teach fsc/fsi how to use responsefile #831

Teach fsc/fsi how to use responsefile #831

enricosada commented Dec 23, 2015

enricosada Dec 23, 2015

enricosada commented Jan 5, 2016

dsyme commented Jan 5, 2016

enricosada commented Jan 7, 2016

mmitche commented Jan 7, 2016

OmarTawfik commented Jan 7, 2016

mmitche commented Jan 7, 2016

enricosada commented Jan 7, 2016

OmarTawfik commented Jan 7, 2016

enricosada commented Jan 7, 2016

OmarTawfik commented Jan 7, 2016

OmarTawfik commented Jan 7, 2016

smoothdeveloper commented Jan 18, 2016

enricosada commented Jan 18, 2016

enricosada commented Jan 18, 2016

KevinRansom commented Jan 20, 2016

enricosada commented Jan 20, 2016

smoothdeveloper commented Jan 20, 2016

Teach fsc/fsi how to use responsefile #831

Teach fsc/fsi how to use responsefile #831

Conversation

enricosada commented Dec 23, 2015

enricosada Dec 23, 2015

Choose a reason for hiding this comment

enricosada commented Jan 5, 2016

dsyme commented Jan 5, 2016

enricosada commented Jan 7, 2016

mmitche commented Jan 7, 2016

OmarTawfik commented Jan 7, 2016

mmitche commented Jan 7, 2016

enricosada commented Jan 7, 2016

OmarTawfik commented Jan 7, 2016

enricosada commented Jan 7, 2016

OmarTawfik commented Jan 7, 2016

OmarTawfik commented Jan 7, 2016

smoothdeveloper commented Jan 18, 2016

enricosada commented Jan 18, 2016

enricosada commented Jan 18, 2016

KevinRansom commented Jan 20, 2016

enricosada commented Jan 20, 2016

smoothdeveloper commented Jan 20, 2016