Proposed protocol addition "set-next-statement" #28

[weinand]

Protocol addition "set-next-statement" (#28) contains:

• a new optional supportsGotoTargetsRequest capability
• a new type GotoTarget
• a new optional gotoTargetsRequest request
• a new optional GotoRequest request

[gregg-miskelly]

LGTM

[gregg-miskelly]

We also need a 'label' string to provide a disambiguation dialog if there is more than one.

[weinand]

@gregg-miskelly yes, makes sense and brings it closer to the similar StepInTarget.

[jacdavis]

IMHO, I think it would be better to adopt the VS model here. Essentially, you'd just need a GotoRequest that takes the file path and line number and can handle errors.

[gregg-miskelly]

@jacdavis that wouldn't work very well with trying to build a debug engine that exposes out the debug protocol - AD7 has a bunch of different SetNextStatement related methods (EnumCodeContexts, CanSetNextStament, IDebugCodeContex2.Compare, SetNextStatement) with a disambiguation dialog in between some of them. I think we can safely combine EnumCodeContexts+CanSetNextStatement in the enumeration API. But I think if we try and combine them all together will not be able to create a debug engine that can support this.

[jacdavis]

That’s right, I forgot about EnumCodeContexts. I guess we already have the scalability issue even in vs.

From: Gregg Miskelly [mailto:notifications@github.com]
Sent: Monday, July 18, 2016 10:28 AM
To: Microsoft/vscode-debugadapter-node vscode-debugadapter-node@noreply.github.com
Cc: Jackson Davis Jackson.Davis@microsoft.com; Mention mention@noreply.github.com
Subject: Re: [Microsoft/vscode-debugadapter-node] Proposed protocol addition "set-next-statement" #28 (#45)

@jacdavishttps://github.com/jacdavis that wouldn't work very well with trying to build a debug engine that exposes out the debug protocol - AD7 has a bunch of different SetNextStatement related methods (EnumCodeContexts, CanSetNextStament, IDebugCodeContex2.Compare, SetNextStatement) with a disambiguation dialog in between some of them. I think we can safely combine EnumCodeContexts+CanSetNextStatement in the enumeration API. But I think if we try and combine them all together will not be able to create a debug engine that can support this.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/45#issuecomment-233398311, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AM3W_cIcP9fgc1LU_B4Eic3G6Z3PhOpwks5qW7ejgaJpZM4JO2mq.

[weinand]

I've merged the PR and added a label attribute to the GotoTarget.