Make the shell attach command customizable #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
this looks better than #159. Can we close that one and only take this one? |
|
Yeah that makes sense |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to specify the shell command to be used when attaching to containers by using the settings
docker.attachShellCommand.LinuxContaineranddocker.attachShellCommand.windowsContainerDefaulting to the current commands
/bin/shandpowershellThis closes, or partly closes, #60.
Depending on if you want the user to be able to specify the shell command to run in "runtime" or only using the settings as this PR provides.
(the former makes the ease of just right clicking a container and pressing
Attach Shella bit worse in my opinion since you would then have to specify the attach command anyways)