Change promptOnSystemPrune default #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdias
approved these changes
Feb 6, 2018
|
Since there have been multiple issues regarding prune, I think it makes sense to change the default. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #183
Clicking System Prune does not produce the necessary warnings that Docker normally products when you run a system prune. The icon is also unlabelled and easy to mis-click so close the to the Refresh and resize grabber. It also insufficiently explains purpose.
This will restore the prompt that was there before as a default but allow those that are fully aware of consequences to disable the prompt, so that any new users are fully informed of consequences. Might be worth checking the messaging explains that volumes are removed too as that was a little unexpected.