Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

gocode is broken on current go git master #1645

Closed
OneOfOne opened this issue Apr 25, 2018 · 6 comments
Closed

gocode is broken on current go git master #1645

OneOfOne opened this issue Apr 25, 2018 · 6 comments
Milestone

Comments

@OneOfOne
Copy link
Contributor

Steps to Reproduce:

  1. use current go git master.
  2. get PANIC when you try to auto complete.

Possible fixes:

Just installing either of those will override nsf's gocode and you just can run killall -9 gocode without restarting vscode.

@OneOfOne
Copy link
Contributor Author

OneOfOne commented May 1, 2018

@FiloSottile
Copy link
Contributor

From https://github.com/nsf/gocode/blob/9d1e0378d/README.md:

IMPORTANT: consider switching to https://github.com/mdempsky/gocode if you have problems starting with Go version 1.10, due to changes in binary packages architecture (introduction of package cache) I'm not going to adjust gocode for it for quite some time. There is a higher chance that fork under the given link will have some solution to the problem sooner or later.

@mccolljr
Copy link

Out of curiousity, has this been addressed? Is this package going to move to github.com/mdempsky/gocode? Manually installing and switching to that fork of gocode stops the PANIC messages and gets me completion again. Even gocode's original author recommends switching to the fork, so I think this would be the right move. Or, at least provide a setting for which fork to use?

@localvar
Copy link

localvar commented Jun 3, 2018

just FYI: To improve the performance of https://github.com/mdempsky/gocode, I create another temporary folk at: https://github.com/localvar/gocode

@ramya-rao-a
Copy link
Contributor

Well, I did give this a try, but the completion tests for all versions of Go started failing in travis.
See https://github.com/Microsoft/vscode-go/commits/new-gocode

If anyone can figure that out, then yes, we can move to github.com/mdempsky/gocode

@ramya-rao-a
Copy link
Contributor

Fixed with #1710 thanks to @m90
The fix is out in today's update to the Go extension (0.6.82)

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants