Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Allow using dlv v2 apis when debugging tests via codelens or debug files without config #1735

Closed
ramya-rao-a opened this issue Jun 15, 2018 · 3 comments

Comments

@ramya-rao-a
Copy link
Contributor

At present there is no way to use dlv v2 apis when debugging tests via codelens or debuggging files without a debug config in the launch.json file.

See #1555 (comment)

@lggomez
Copy link
Contributor

lggomez commented Jun 17, 2018

I can work on this, it's a pity I couldn't make it to 0.6.83

To recap: the change has be done here: https://github.com/Microsoft/vscode-go/blob/0.6.82/src/goRunTestCodelens.ts

As you mentioned in #1555 (comment), currently there isn't a straightforward way to bypass the hardcoded config in the codelens provider and use the launch config from there. That would have been the prefered way since it would be really dynamic and only tied to the actual debug configuration selected by the user

Either way, we still have to be able to access the settings from the provider if we wanna make this optional to follow the intended transition to v2 plan

@ramya-rao-a
Copy link
Contributor Author

To recap: the change has be done here: https://github.com/Microsoft/vscode-go/blob/0.6.82/src/goRunTestCodelens.ts

Am confused... You have already done the changes or you are providing a pointer as to where the change has to be made?

Let me know if you have any questions or want me to take a stab at this.

@lggomez
Copy link
Contributor

lggomez commented Jun 18, 2018

It is just a reminder on this new issue. I haven't started any work on this yet

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants