Using vscode-go from multiple user accounts clashes on /tmp/go-code-check

[lmb]

Steps to Reproduce:

1. On a system where TMPDIR is shared for the whole machine (e.g. Ubuntu)
2. Create two user accounts A and B
3. Work on Go code with A
4. Switch to user B, work on Go code
5. Observe error message

go build package/name: open /tmp/go-code-check: permission denied

$ ls -lh /tmp/go-code-check
-rw-rw-r-- 1 private private 173K Aug  7 22:54 /tmp/go-code-check

I believe this is due to https://github.com/Microsoft/vscode-go/blob/a1b8648a0b2ef5858669fa648a438f79c668f256/src/goBuild.ts#L59 assuming that TMP is exclusive to a user, which isn't the case on a default Ubuntu install.

[ramya-rao-a]

What do you suggest we do instead?

[lmb]

Option 1: generate a random subdirectory, see https://golang.org/src/io/ioutil/tempfile.go?s=2138:2195#L66 Option 2: include the UID in the temp file name.

…

On 8 August 2018 23:19:51 Ramya Rao ***@***.***> wrote: What do you suggest we do instead? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[ramya-rao-a]

Thanks for logging this issue @lmb and Thanks for the PR @rikkuness! Your fix is now available in the latest update (0.6.86) to the Go extension

[lmb]

Thank you both for the quick fix!

…

On 13 August 2018 23:28:28 Ramya Rao ***@***.***> wrote: Thanks for logging this issue @lmb and Thanks for the PR @rikkuness! Your fix is now available in the latest update (0.6.86) to the Go extension — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.