Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Debugger compares length of bytes instead of length of string for hov… #1790

Merged
merged 1 commit into from
Jul 16, 2018
Merged

Debugger compares length of bytes instead of length of string for hov… #1790

merged 1 commit into from
Jul 16, 2018

Conversation

xmattstrongx
Copy link
Contributor

Fixes #1777

image

image

ramya-rao-a
ramya-rao-a suggested changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can avoid calling Buffer.byteLength twice by pulling it out say like let byteLength = Buffer.byteLength(val || '');

ramya-rao-a
ramya-rao-a approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ramya-rao-a ramya-rao-a merged commit 195d4d7 into microsoft:master Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xmattstrongx @ramya-rao-a