Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

goMain.ts add commands to Go: Show All Commands #1952

Merged
merged 2 commits into from
Oct 10, 2018

Conversation

vimalk78
Copy link
Contributor

@vimalk78 vimalk78 commented Oct 1, 2018

commands added :

  • Go to definition
  • Go to implementation
  • Go to symbol in file
  • Go to symbol in workspace

fixes #1822

commands added :
 * Go to definition
 * Go to implementation
 * Go to symbol in file
 * Go to symbol in workspace

fixes microsoft#1822
@vimalk78 vimalk78 closed this Oct 1, 2018
@vimalk78 vimalk78 reopened this Oct 1, 2018
@vimalk78
Copy link
Contributor Author

vimalk78 commented Oct 1, 2018

screen shot 2018-10-01 at 1 39 40 pm

The four commands are added to Go : Show all commands...

@vimalk78
Copy link
Contributor Author

vimalk78 commented Oct 1, 2018

not sure why the CI is failing

screen shot 2018-10-01 at 5 24 09 pm

@vimalk78 vimalk78 closed this Oct 1, 2018
@vimalk78 vimalk78 reopened this Oct 1, 2018
@vimalk78 vimalk78 closed this Oct 2, 2018
@vimalk78 vimalk78 reopened this Oct 2, 2018
@vimalk78
Copy link
Contributor Author

vimalk78 commented Oct 3, 2018

@ramya-rao-a , does this look OK?

@vimalk78 vimalk78 closed this Oct 7, 2018
@vimalk78 vimalk78 reopened this Oct 7, 2018
@vimalk78
Copy link
Contributor Author

vimalk78 commented Oct 7, 2018

@ramya-rao-a , please check.

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @vimalk78, I got busy with VS Code release.

This looks great, I've updated the title for 2 commands and removed the description as they dont get shown in the UI.

@ramya-rao-a ramya-rao-a merged commit 8c57367 into microsoft:master Oct 10, 2018
@ramya-rao-a
Copy link
Contributor

Also, I see that this is your first contribution to vscode-go. Welcome & Thanks!

@vimalk78
Copy link
Contributor Author

thanks for your help !!
how do i claim the hactoberfest t-shirt :)

@ramya-rao-a
Copy link
Contributor

The details must be in https://open.microsoft.com/2018/09/18/hacktoberfest-2018-microsoft/
That's all I know :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Go to implementation cmd to the Go: Show all Commands for better discoverability
2 participants