Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Update packages #2014

Merged
merged 4 commits into from
Oct 20, 2018
Merged

Update packages #2014

merged 4 commits into from
Oct 20, 2018

Conversation

alexdor
Copy link
Contributor

@alexdor alexdor commented Oct 16, 2018

Updated to newer packages in order to leverage new typescript features, also it fixes some vulnerabilities that npm was reporting

@msftclas
Copy link

msftclas commented Oct 16, 2018

CLA assistant check
All CLA requirements met.

package.json Outdated
"vscode": "^1.1.21"
},
"engines": {
"vscode": "^1.22.0"
"vscode": "^1.26.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for this change?
This change will result in the next update to the Go extension not being available to anyone who is on versions of VS Code older than 1.26.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There where typing issues with one of the dependencies with the 1.22 version, I based my solution on this microsoft/language-server-protocol#556 (comment) comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, lets not update any of the vscode- dependencies just yet.

I usually prefer to wait till we are atleast 3 versions away from the minimum specified in the engine property. Unless, of course there is a bug fix that we need to take in immediately.

test/go.test.ts Outdated
@@ -804,7 +801,7 @@ It returns the number of bytes written and any write error encountered.
return vscode.window.showTextDocument(textDocument).then(editor => {
let promises = testCases.map(([position, expected]) =>
provider.provideCompletionItems(editor.document, position, null).then(items => {
let labels = items.map(x => x.label);
let labels = items.items.map(x => x.label);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged another PR that fixed the tests, can you revert your changes to this file?

@alexdor
Copy link
Contributor Author

alexdor commented Oct 20, 2018

I've updated all the packages except vscode-languageclient which is the one package that requires a newer vscode version, so it can be merged without changing the engine version

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@ramya-rao-a ramya-rao-a merged commit 833445d into microsoft:master Oct 20, 2018
@ramya-rao-a
Copy link
Contributor

Thanks for the PR @alexdor!

Also, I see that this is your first contribution to vscode-go. Welcome & Thanks!
I hope that you have registered both for the Microsoft Hacktoberfest and the one from Digitalocean

Happy Coding!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants