Use gopls for language server #2383

ramya-rao-a · 2019-03-18T03:59:03Z

Now that the language server from Google is ready for use, there are some changes needed in the Go extension to ensure good user experience

Allow installing of the gopls language server using Go: Install/Update Tools
Prompt users who use the language server from Sourcegraph to switch to the one from Google
Disable build on save feature when using gopls or bingo to avoid duplicate errors
Enable format and auto-completion features from the language servers

Edit as per latest commits:

If using modules but not any language server, users will now be prompted to install and use gopls
If using Sourcegraph, users will now be prompted to install and use gopls or stop disable the go.useLanguageServer setting
For anyone setting go.useLanguageServer for the first time, gopls will be installed and used
diagnostics is added to go.languageServerExperimentalFeatures setting so that user can control if they want the language server to return build/vet errors. Set to true by default. When enabled, the build and vet on save features of the extension will not be run to avoid duplicate errors
README updated

cc @stamblerre, @ianthehat

stamblerre · 2019-03-18T04:18:03Z

This looks great, thank you for doing this! The only thing I noticed is that with gopls, you will want to disable vet on save as well as build on save, since gopls also returns vet errors.

ramya-rao-a · 2019-03-18T06:08:07Z

Thanks @stamblerre. Disabled vet on save for gopls as well

@stamblerre, @ianthehat, I pushed a commit for prompting users to use the language server when using modules, as completion is much better there compared to gocode like @stamblerre mentioned before.

My one concern here is the go to definition feature.

When using godef, we realized that the folder from where godef was being run was important to get the right context. How does the language server resolve the context issue?

primalmotion · 2019-03-19T23:00:59Z

this looks awesome. I just tried and everything seems to work smooth. However auto completing imports (like json<tab>) doesn't work anymore. Am I missing something?

mafredri · 2019-03-21T13:59:30Z

Happy to see this coming along! Two issues I've noticed so far after a bit of usage:

Documentation (on hover / cmd hover) seems to be missing, I've tested by not setting go.docsTool and I've tried both godoc and guru. Do you know if it's a limitation of gopls or something else? I've also tried to install all tools via vscode and fetching them manually
The editor/extension ended up in some kind of broken state: vscode lists issues even though they have been fixed, making changes does not help but might shift the problems to point at something else. It's as if it's interpreting old code. Killing gopls did not help, but restarting vscode made the issue disappear

primalmotion · 2019-03-21T15:44:53Z

I also experience the broken state. After a while, errors stay here while they have been fixed, or formatting overlapps basically screwing the entire file by combining two or more outputs. When that happens I have to reload vscode to be back in business

stamblerre · 2019-03-21T19:19:13Z

Completing package names and documentation on hover (without comments, for now) should definitely still work. If you encounter this again, do you mind filing an issue with a repro case on the Go issue tracker?

The stuck diagnostics seem to be an instance of https://golang.org/issue/30786, so we can move the discussion there.

mafredri · 2019-03-21T19:43:57Z

Completing package names and documentation on hover (without comments, for now) should definitely still work.

I'd like to clarify that I was referring to comments, specifically. I do see function/struct signatures although they seem to use a condensed syntax (one line with ; separation instead of newlines).

Thanks for linking to the issue on the go issue tracker.

package.json

vladbarosan · 2019-03-21T21:45:46Z

src/util.ts

+export function getAlternateLanguageServer(goConfig: vscode.WorkspaceConfiguration): string {
+ if (goConfig['useLanguageServer'] === true
+ && goConfig['alternateTools']
+ && goConfig['alternateTools']['go-langserver']


do we need to define this in the package.json file?

If we do, then we need to define all the tools used in the extension as well.

vladbarosan · 2019-03-21T21:54:48Z

src/goInstallTools.ts

@@ -496,9 +513,10 @@ export function checkLanguageServer(): boolean {
 return false;
 }

- let langServerAvailable = getBinPath('go-langserver') !== 'go-langserver';
+ const languageServerOfChoice = getAlternateLanguageServer(latestGoConfig) || 'go-langserver';
+ const langServerAvailable = path.isAbsolute(getBinPath('go-langserver'));


shouldn't we check here for languageServerOfChoice

getBinPath will internally look up alternateTools and do the right thing

src/goInstallTools.ts

src/goCheck.ts

src/goModules.ts

ramya-rao-a · 2019-03-25T05:45:09Z

@primalmotion, @mafredri,
Thanks for trying this out and the early feedback!

All,
I have updated the PR description to include some more changes that I have made as per the latest few commits. Please have a read.

@vladbarosan,
A lot more commits have gone in, so this would need another round of review. Do you mind taking a look?

primalmotion · 2019-03-25T17:55:16Z

@ramya-rao-a updated to latest pr code but I still have the issue where packages are not autocompleted.

primalmotion · 2019-03-26T20:56:03Z

I also still have the errors that I fixed stuck forever until I reload vscode

ramya-rao-a · 2019-03-27T02:41:38Z

@stamblerre By default, I will be disabling the diagnostics feature of the language server. Users can opt into it by using diagnostics in the experimentalfeatures setting. Until the issue of stuck errors are resolved, this is best for the users.

@primalmotion With the latest changes in the PR, you wont get any errors from the language server and the completion of unimported packages should also work as long as you have set go.autcompleteUnimportedPackages setting to true (as before)

primalmotion · 2019-03-27T03:03:11Z

Cool. I'll give a go tomorrow. So to get the build error (cause it's cool) should I reactivate the build on save?

ramya-rao-a · 2019-03-27T05:31:35Z

So to get the build error (cause it's cool) should I reactivate the build on save?

Yes

src/goCheck.ts

src/goInstallTools.ts

vladbarosan · 2019-03-28T20:36:25Z

src/goInstallTools.ts

 const latestGoConfig = vscode.workspace.getConfiguration('go');
- if (!latestGoConfig['useLanguageServer']) return false;
+ if (!latestGoConfig['useLanguageServer']) return;


I wonder if there is a way to get a typed response here, is very annoying that we need to do type checks at runtime :( . ill open an issue

src/goSuggest.ts

src/goMain.ts

src/goPath.ts

src/goSuggest.ts

vladbarosan

Mostly looks good, left some suggestions

ramya-rao-a · 2019-03-28T21:38:57Z

Thanks @vladbarosan, I have addressed most of the comments

primalmotion · 2019-03-28T23:08:44Z

\o/

stamblerre · 2019-03-28T23:11:25Z

Thank you @ramya-rao-a, @vladbarosan, and everyone else who contributed to this! We really appreciate your work on getting gopls in VSCode 😄 Looking forward to our continued collaboration and improvements to VSCode-Go!

primalmotion · 2019-03-29T01:13:08Z

well.. now goals crashes every few seconds..

[Trace - 6:10:02 PM] Sending notification 'textDocument/didOpen'.
Params: {"textDocument":{"uri":"file:///Users/tonio/Documents/Aporeto/workspace/code/go/src/go.aporeto.io/backend/srv/squall/internal/cleaning/processingunits.go","languageId":"go","version":3,"text":"package cleaning\n\nimport (\n\t\"context\"\n\t\"math/rand\"\n\t\"time\"\n\n\t\"go.aporeto.io/backend/internal/crudcore\"\n\t\"go.aporeto.io/elemental\"\n\t\"go.aporeto.io/gaia\"\n\t\"go.aporeto.io/manipulate\"\n\t\"go.aporeto.io/underwater/core/tagutils\"\n\t\"go.uber.org/zap\"\n)\n\n// DeleteProcessingUnitsOfEnforcer deletes all the processing units managed by the pu with the given ID.DeleteProcessingUnitsOfEnforcer\n// It will return a list of elemental.Events containing the pus deleted.\nfunc DeleteProcessingUnitsOfEnforcer(ctx context.Context, m manipulate.TransactionalManipulator, puID string) ([]*elemental.Event, error) {\n\n\tmctx := manipulate.NewContext(\n\t\tctx,\n\t\tmanipulate.ContextOptionFilter(\n\t\t\tmanipulate.NewFilterComposer().\n\t\t\t\tWithKey(\"puid\").Equals(puID).\n\t\t\t\tWithKey(\"archived\").Equals(false).\n\t\t\t\tDone(),\n\t\t),\n\t)\n\n\tvar pus gaia.ProcessingUnitsList\n\tif err := m.RetrieveMany(mctx, &pus); err != nil {\n\t\treturn nil, err\n\t}\n\n\tevents := make([]*elemental.Event, len(pus))\n\tfor i, pu := range pus {\n\t\tif err := crudcore.Delete(ctx, m, \"\", manipulate.WriteConsistencyDefault, pu, true); err != nil {\n\t\t\treturn nil, err\n\t\t}\n\t\tevents[i] = elemental.NewEvent(elemental.EventDelete, pu)\n\t}\n\n\treturn events, nil\n}\n\nconst (\n\tpuUnresponsiveTimeout  = 5 * time.Minute\n\tpuDeletionTimeout      = 24 * time.Hour\n\tpuCollectedInfoTimeout = 24 * time.Hour\n)\n\n// CleanProcessingUnitJob cleans pu collected info or unresponsive.\nfunc CleanProcessingUnitJob(ctx context.Context, m manipulate.TransactionalManipulator, pushFunc func(...*elemental.Event)) {\n\n\tr := time.Duration(rand.Intn(1)) * time.Minute\n\n\tcleanEnforcerCollectedInfo(ctx, m)\n\tmarkUnresponsiveProcessingUnit(ctx, m, pushFunc)\n\tdeleteUnknownProcessingUnit(ctx, m, pushFunc)\n\n\tcleanCollectedInfoTicker := time.NewTicker(puCollectedInfoTimeout + r)\n\tdefer cleanCollectedInfoTicker.Stop()\n\n\tunresponsiveTicker := time.NewTicker(puUnresponsiveTimeout + r)\n\tdefer unresponsiveTicker.Stop()\n\n\tdeletionTicker := time.NewTicker(puDeletionTimeout + r)\n\tdefer deletionTicker.Stop()\n\n\tfor {\n\t\tselect {\n\n\t\tcase <-unresponsiveTicker.C:\n\t\t\tmarkUnresponsiveProcessingUnit(ctx, m, pushFunc)\n\n\t\tcase <-deletionTicker.C:\n\t\t\tdeleteUnknownProcessingUnit(ctx, m, pushFunc)\n\n\t\tcase <-cleanCollectedInfoTicker.C:\n\t\t\tcleanEnforcerCollectedInfo(ctx, m)\n\n\t\tcase <-ctx.Done():\n\t\t\treturn\n\t\t}\n\t}\n}\n\nfunc markUnresponsiveProcessingUnit(ctx context.Context, m manipulate.TransactionalManipulator, pushFunc func(...*elemental.Event)) {\n\n\tfilter := manipulate.NewFilterComposer().\n\t\tWithKey(\"operationalstatus\").Equals(gaia.EnforcerOperationalStatusConnected).\n\t\tWithKey(\"lastpoketime\").LesserThan(time.Now().Add(-puUnresponsiveTimeout)).\n\t\tDone()\n\n\tvar pus gaia.ProcessingUnitList\n\tvar mctx manipulate.Context\n\n\tpage := 0\n\tpageSize := 100\n\tnow := time.Now()\n\n\tfor {\n\n\t\tpage++\n\n\t\tpus = gaia.ProcessingUnitList{}\n\t\tmctx = manipulate.NewContext(\n\t\t\tctx,\n\t\t\tmanipulate.ContextOptionOrder(\"id\"),\n\t\t\tmanipulate.ContextOptionFilter(filter),\n\t\t\tmanipulate.ContextOptionPage(page, pageSize),\n\t\t)\n\n\t\tif err := m.RetrieveMany(mctx, &pus); err != nil {\n\t\t\tzap.L().Error(\"Unable to retrieve list of outdated pus\", zap.Error(err))\n\t\t\tbreak\n\t\t}\n\n\t\tif len(pus) == 0 {\n\t\t\tbreak\n\t\t}\n\n\t\tfor _, pu := range pus {\n\n\t\t\tpu.OperationalStatus = gaia.EnforcerOperationalStatusUnknown\n\t\t\tpu.UpdateTime = now\n\t\t\tpu.NormalizedTags = tagutils.Normalize(pu)\n\n\t\t\tif err := m.Update(nil, pu); err != nil {\n\t\t\t\tzap.L().Error(\"Unable to update operational status of pu\",\n\t\t\t\t\tzap.String(\"id\", pu.ID),\n\t\t\t\t\tzap.Error(err),\n\t\t\t\t)\n\t\t\t}\n\n\t\t\tpushFunc(elemental.NewEvent(elemental.EventUpdate, pu))\n\t\t}\n\t}\n}\n\nfunc deleteUnknownProcessingUnit(ctx context.Context, m manipulate.TransactionalManipulator, pushFunc func(...*elemental.Event)) {\n\n\tfilter := manipulate.NewFilterComposer().\n\t\tWithKey(\"operationalstatus\").Equals(gaia.EnforcerOperationalStatusUnknown).\n\t\tWithKey(\"lastpoketime\").LesserThan(time.Now().Add(-puDeletionTimeout)).\n\t\tDone()\n\n\tvar pus gaia.ProcessingUnitList\n\tvar mctx manipulate.Context\n\n\tpage := 0\n\tpageSize := 100\n\n\tfor {\n\n\t\tpage++\n\n\t\tpus = gaia.ProcessingUnitList{}\n\t\tmctx = manipulate.NewContext(\n\t\t\tctx,\n\t\t\tmanipulate.ContextOptionOrder(\"id\"),\n\t\t\tmanipulate.ContextOptionFilter(filter),\n\t\t\tmanipulate.ContextOptionPage(page, pageSize),\n\t\t)\n\n\t\tif err := m.RetrieveMany(mctx, &pus); err != nil {\n\t\t\tzap.L().Error(\"Unable to retrieve the list of pu to delete\", zap.Error(err))\n\t\t\tcontinue\n\t\t}\n\n\t\tif len(pus) == 0 {\n\t\t\tbreak\n\t\t}\n\n\t\tfor _, pu := range pus {\n\n\t\t\tif err := m.Delete(nil, pu); err != nil {\n\t\t\t\tzap.L().Error(\"Unable to delete pu\",\n\t\t\t\t\tzap.String(\"id\", pu.ID),\n\t\t\t\t\tzap.Error(err),\n\t\t\t\t)\n\t\t\t\tcontinue\n\t\t\t}\n\n\t\t\tevents, err := DeleteProcessingUnitsOfEnforcer(ctx, m, pu.ID)\n\t\t\tif err != nil {\n\t\t\t\tzap.L().Error(\"Unable to delete pus managed by pu\",\n\t\t\t\t\tzap.String(\"id\", pu.ID),\n\t\t\t\t\tzap.Error(err),\n\t\t\t\t)\n\t\t\t\tcontinue\n\t\t\t}\n\n\t\t\tevents = append(events, elemental.NewEvent(elemental.EventDelete, pu))\n\n\t\t\tpushFunc(events...)\n\t\t}\n\t}\n}\n\nfunc cleanEnforcerCollectedInfo(ctx context.Context, m manipulate.Manipulator) {\n\n\tctx, cancel := context.WithTimeout(ctx, 10*time.Minute)\n\tdefer cancel()\n\n\tmctx := manipulate.NewContext(\n\t\tctx,\n\t\tmanipulate.ContextOptionFilter(\n\t\t\tmanipulate.NewFilterComposer().\n\t\t\t\tWithKey(\"lastcollectiontime\").LesserThan(time.Now().Add(-puCollectedInfoTimeout)).\n\t\t\t\tWithKey(\"lastcollectiontime\").NotEquals(time.Time{}).\n\t\t\t\tDone(),\n\t\t),\n\t)\n\n\tdest := &gaia.ProcessingUnitList{}\n\tif err := manipulate.Retry(ctx, func() error { return m.RetrieveMany(mctx, dest) }, nil); err != nil {\n\t\tzap.L().Error(\"Could not retrieve pus\", zap.Error(err))\n\t}\n\n\tpus := dest.List()\n\tif len(pus) == 0 {\n\t\treturn\n\t}\n\n\tfor _, i := range pus {\n\t\te := i.(*gaia.Enforcer)\n\t\te.CollectedInfo = map[string]string{}\n\t\te.LastCollectionTime = time.Time{}\n\t}\n\n\tmctx = manipulate.NewContext(ctx)\n\tif err := manipulate.Retry(ctx, func() error { return m.Update(mctx, pus...) }, nil); err != nil {\n\t\tzap.L().Error(\"Could not update pus\", zap.Error(err))\n\t}\n\n\tzap.L().Debug(\"ProcessingUnit debug cleaned\")\n}\n"}}


[Trace - 6:10:02 PM] Received response 'workspace/configuration - (1)' in 2ms.
Params: [null]


[Trace - 6:10:02 PM] Received notification 'window/logMessage'.
Params: {"type":1,"message":"Invalid config gopls type \u003cnil\u003e"}


[Error - 6:10:02 PM] Invalid config gopls type <nil>
[Trace - 6:10:02 PM] Sending request 'textDocument/documentSymbol - (1)'.
Params: {"textDocument":{"uri":"file:///Users/tonio/Documents/Aporeto/workspace/code/go/src/go.aporeto.io/backend/srv/squall/internal/cleaning/processingunits.go"}}


panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x131e558]

goroutine 4 [running]:
golang.org/x/tools/internal/lsp/source.funcSymbol(0xc00055a720, 0x0, 0x0, 0xc0000be140, 0xc019e6ace0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/Users/tonio/Documents/Aporeto/workspace/code/go/src/golang.org/x/tools/internal/lsp/source/symbols.go:68 +0x58
golang.org/x/tools/internal/lsp/source.DocumentSymbols(0x14c52c0, 0xc0000be300, 0x14c7740, 0xc00012bd60, 0xc0001e2090, 0x81, 0x14c7740)
	/Users/tonio/Documents/Aporeto/workspace/code/go/src/golang.org/x/tools/internal/lsp/source/symbols.go:49 +0x912
golang.org/x/tools/internal/lsp.(*server).DocumentSymbol(0xc00002ad40, 0x14c52c0, 0xc0000be300, 0xc00019a980, 0xc00019a980, 0x0, 0x0, 0x102cd11, 0x1451dc0)
	/Users/tonio/Documents/Aporeto/workspace/code/go/src/golang.org/x/tools/internal/lsp/server.go:484 +0x100
golang.org/x/tools/internal/lsp/protocol.serverHandler.func1(0x14c52c0, 0xc0000be300, 0xc0001723f0, 0xc000199040)
	/Users/tonio/Documents/Aporeto/workspace/code/go/src/golang.org/x/tools/internal/lsp/protocol/server.go:274 +0x399f
golang.org/x/tools/internal/jsonrpc2.(*Conn).run(0xc0001723f0, 0x14c5300, 0xc00001c0e0, 0x0, 0x0)
	/Users/tonio/Documents/Aporeto/workspace/code/go/src/golang.org/x/tools/internal/jsonrpc2/jsonrpc2.go:327 +0x67b
golang.org/x/tools/internal/jsonrpc2.NewConn.func4(0xc0001723f0, 0x14c5300, 0xc00001c0e0)
	/Users/tonio/Documents/Aporeto/workspace/code/go/src/golang.org/x/tools/internal/jsonrpc2/jsonrpc2.go:107 +0x3f
created by golang.org/x/tools/internal/jsonrpc2.NewConn
	/Users/tonio/Documents/Aporeto/workspace/code/go/src/golang.org/x/tools/internal/jsonrpc2/jsonrpc2.go:106 +0x18d
[Error - 6:10:05 PM] Connection to server got closed. Server will not be restarted.
[Error - 6:10:05 PM] Request textDocument/documentSymbol failed.
Error: Connection got disposed.
	at Object.dispose (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/main.js:876:25)
	at Object.dispose (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-languageclient/lib/client.js:57:35)
	at LanguageClient.handleConnectionClosed (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-languageclient/lib/client.js:2019:42)
	at LanguageClient.handleConnectionClosed (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-languageclient/lib/main.js:126:15)
	at closeHandler (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-languageclient/lib/client.js:2006:18)
	at CallbackList.invoke (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/events.js:62:39)
	at Emitter.fire (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/events.js:120:36)
	at closeHandler (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/main.js:226:26)
	at CallbackList.invoke (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/events.js:62:39)
	at Emitter.fire (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/events.js:120:36)
	at StreamMessageReader.fireClose (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/messageReader.js:111:27)
	at Socket.listen.readable.on (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/messageReader.js:151:46)
	at Socket.emit (events.js:187:15)
	at Pipe.Socket._destroy._handle.close [as _onclose] (net.js:596:12)
[Error - 6:10:05 PM] Request textDocument/codeAction failed.
Error: Connection got disposed.
	at Object.dispose (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/main.js:876:25)
	at Object.dispose (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-languageclient/lib/client.js:57:35)
	at LanguageClient.handleConnectionClosed (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-languageclient/lib/client.js:2019:42)
	at LanguageClient.handleConnectionClosed (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-languageclient/lib/main.js:126:15)
	at closeHandler (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-languageclient/lib/client.js:2006:18)
	at CallbackList.invoke (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/events.js:62:39)
	at Emitter.fire (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/events.js:120:36)
	at closeHandler (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/main.js:226:26)
	at CallbackList.invoke (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/events.js:62:39)
	at Emitter.fire (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/events.js:120:36)
	at StreamMessageReader.fireClose (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/messageReader.js:111:27)
	at Socket.listen.readable.on (/Users/tonio/.vscode/extensions/ms-vscode.go-0.9.3-beta4/node_modules/vscode-jsonrpc/lib/messageReader.js:151:46)
	at Socket.emit (events.js:187:15)
	at Pipe.Socket._destroy._handle.close [as _onclose] (net.js:596:12)

stamblerre · 2019-03-29T05:21:35Z

@primalmotion: Are you using gopls at the latest commit? I'm not able to reproduce, but if you are at tip, please file an issue here.

primalmotion · 2019-03-29T06:00:57Z

I was on the tip. Then I upgraded go tools with vscode and it started to fail.
I go installed it again manually and now it works. Weird

Accomodate gopls

d353708

ramya-rao-a assigned jhendrixMSFT and vladbarosan Mar 18, 2019

Update prompt msg to include note on modules

be45f42

Prompt gopls for modules

a4c6f0b

ramya-rao-a changed the title ~~Accomodate gopls~~ Use gopls for language server Mar 18, 2019

Disable vet on save when using gopls

ea123d0

stamblerre mentioned this pull request Mar 21, 2019

x/tools/internal/lsp: build errors linger after they are saved golang/go#30786

Closed

vladbarosan reviewed Mar 21, 2019

View reviewed changes

package.json Show resolved Hide resolved

vladbarosan reviewed Mar 21, 2019

View reviewed changes

src/goInstallTools.ts Outdated Show resolved Hide resolved

vladbarosan reviewed Mar 21, 2019

View reviewed changes

src/goCheck.ts Outdated Show resolved Hide resolved

vladbarosan reviewed Mar 21, 2019

View reviewed changes

src/goModules.ts Show resolved Hide resolved

ramya-rao-a added 6 commits March 24, 2019 19:08

Make gopls the default language server

d63d887

Allow disabling diagnostics from language server

17e8b9c

Merge remote-tracking branch 'Microsoft/master' into gopls

82a200b

Revert changes that are not needed anymore

e47c5a1

Remove unused function

b2f3c54

Refactor for better readability

a5813f5

Update README

813a8e4

ramya-rao-a added 2 commits March 26, 2019 16:58

Disable diagnostics from language server by default

ca0c3d6

complete unimported pkg when using language server

e4c79a0