This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Added configuration for alternate gopls path. #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to allow configuring an alternate path for gopls as well. Everything else in the extension is ready for this configuration, but the configuration feature itself is missing. By "ready" I mean this lines: https://github.com/microsoft/vscode-go/blob/4b516f9a872f3a3086d6d56f8e346d4b5a7e53ef/src/goInstallTools.ts#L559 https://github.com/microsoft/vscode-go/blob/4b516f9a872f3a3086d6d56f8e346d4b5a7e53ef/src/util.ts#L375
ramya-rao-a
approved these changes
Jul 26, 2019
There was a problem hiding this comment.
Looks like this is your first PR contribution to this project @anurbol, Thanks & Welcome!
Am curious as to what alternative are you hoping to use for gopls?
|
@ramya-rao-a Hi! I am making a tooling software and I want to reuse gopls' symbols to avoid parsing source files again. To do that I want to use a proxy between gopls and vscode-go. That proxy is the alternative (and I'll have to make it). |
|
Understood, good luck! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow configuring an alternate path for gopls as well. Everything else in the extension is ready for this configuration, but the configuration feature itself is missing. By "ready" I mean these lines:
vscode-go/src/goInstallTools.ts
Line 559 in 4b516f9
vscode-go/src/util.ts
Line 375 in 4b516f9