This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Debug: Improve 'bad access' error message #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polinasok
commented
Apr 20, 2020
| } | ||
|
|
||
| logError(message + ' - ' + errorMessage); | ||
|
|
||
| if (errorMessage === 'bad access') { |
There was a problem hiding this comment.
This never gets printed because by the time we get to this line, 'bad access' has already been wiped out by the previous statements. I don't think this message is necessary - the stack trace is printed with "last known" comment, which implies that it might not be the expected most recent state.
|
cc @lggomez |
jhendrixMSFT
approved these changes
Apr 22, 2020
|
LGTM |
|
The latest update 0.14.2 has this change, Thanks @polinasok |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the error message that is printed to the user when delve returns "bad access".
Updates #1903.