This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Open Test Files #590
Merged
Open Test Files #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
force-pushed
the
jump-to-test
branch
from
761cd43 to
245aa29
Compare
roblourens
approved these changes
Nov 1, 2016
|
|
||
| let message = stdout; | ||
| let testsGenerated = false; | ||
| if (stdout.startsWith(generatedWord)) { |
There was a problem hiding this comment.
A comment about the output you expect and what you want to transform it to will make this easier to debug if it changes some day.
|
|
||
| if (testsGenerated) { | ||
| vscode.window.showInformationMessage(message, 'Open Generated Test for current file').then(selected => { | ||
| if (selected === 'Open Generated Test for current file') { |
There was a problem hiding this comment.
Extract this string? And i'm not sure 'Generated Test' should be capitalized.
ramya-rao-a
force-pushed
the
jump-to-test
branch
from
245aa29 to
8e7d352
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing Feature Requests from #432 and #566