Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show the "Do you want to install extension" modal dialog if triggered from the run button #10548

Closed
IanMatthewHuff opened this issue Jun 23, 2022 · 0 comments · Fixed by #10549
Closed

Only show the "Do you want to install extension" modal dialog if triggered from the run button #10548

IanMatthewHuff opened this issue Jun 23, 2022 · 0 comments · Fixed by #10549
Assignees
@IanMatthewHuff

Comments

@IanMatthewHuff
Copy link
Member

IanMatthewHuff commented Jun 23, 2022 •
edited
Loading

Per feedback from Jim. The modal dialog to confirm extension install should only be shown when activated from the run command. If you directly pick the kernel command in the kernel picker, then don't show it.
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 23, 2022
@IanMatthewHuff IanMatthewHuff self-assigned this Jun 23, 2022
@IanMatthewHuff IanMatthewHuff mentioned this issue Jun 23, 2022
Merged
9 tasks
@rchiodo rchiodo removed the triage-needed Issue needs to be triaged label Jun 23, 2022
Repository owner moved this from 🏃‍♀️ to 🎉 in 🐍📔 Getting Started Jun 24, 2022
@IanMatthewHuff IanMatthewHuff mentioned this issue Jun 27, 2022
Closed
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@IanMatthewHuff IanMatthewHuff

Labels
None yet
Projects
No open projects
🐍📔 Getting Started
Status: 🎉
Milestone
No milestone
2 participants
@IanMatthewHuff @rchiodo