Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some python settings not migrated to jupyter extension correctly #1088

Closed
janosh opened this issue Nov 12, 2020 · 1 comment
Closed

Some python settings not migrated to jupyter extension correctly #1088

janosh opened this issue Nov 12, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@janosh
Copy link
Contributor

janosh commented Nov 12, 2020

It appears the VS Code Jupyter extension was recently auto-installed on my machine, presumably by the Python extension.

It seems to have done a decent job of porting my existing data science settings over to the new extension, e.g.

- "python.datascience.magicCommandsAsComments": true,
+ "jupyter.magicCommandsAsComments": true,

However, after the transition, the interactive window was no longer showing any code lenses. Took me a minute to figure out that's because the settings had been renamed and they now needed to be called

- "jupyter.codeLenses": "python.datascience.runcell, python.datascience.runallcellsabove, python.datascience.runcellandallbelow, python.datascience.debugcell",
+ "jupyter.codeLenses": "jupyter.runcell, jupyter.runallcellsabove, jupyter.runcellandallbelow, jupyter.debugcell",

Only the JSON key "python.datascience.codeLenses" had been automatically renamed, not the string itself. I think it's worth triggering another automatic rewrite of user settings that handles this change so others don't encounter the same issue and perhaps spend longer on figuring out why their code lenses disappeared.

Second, some of my custom keybindings stopped working as well. E.g. I had

{
  "key": "ctrl+shift+enter",
  "command": "python.datascience.runallcells"
}

which now just triggers a warning

command 'python.datascience.runallcells' not found

Perhaps those can be auto-migrated as well.

@karthiknadig karthiknadig transferred this issue from microsoft/vscode-python Nov 12, 2020
@DonJayamanne
Copy link
Contributor

Thanks for filing this issue & I'm sorry you had to migrate these settings manually.
Looks like we missed some settings when migrating the settings to the new extension.

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Nov 12, 2020
@joyceerhl joyceerhl self-assigned this Nov 16, 2020
@greazer greazer changed the title Glitches due to vscode-jupyter transition Some python settings not migrated to jupyter extension correctly (Was: Glitches due to vscode-jupyter transition) Nov 16, 2020
@greazer greazer added this to the November 2020 Point Release milestone Nov 20, 2020
@janosh janosh changed the title Some python settings not migrated to jupyter extension correctly (Was: Glitches due to vscode-jupyter transition) Some python settings not migrated to jupyter extension correctly Dec 1, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

4 participants