Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-raw (start Jupyter Server) kernels for VSC Native Notebooks #1215

Closed
DonJayamanne opened this issue Aug 4, 2020 · 6 comments
Closed

Support non-raw (start Jupyter Server) kernels for VSC Native Notebooks #1215

DonJayamanne opened this issue Aug 4, 2020 · 6 comments
Assignees
@DonJayamanne

Comments

@DonJayamanne
Copy link
Contributor

Today it only supports raw kernels, not tested with Jupyter (ie. spin up jupyter and connect to it using the jupyter API)
@DonJayamanne DonJayamanne changed the title Support non-raw kernels for VSC Native Notebooks Support non-raw (start Jupyter Server) kernels for VSC Native Notebooks Sep 10, 2020
@rchiodo rchiodo assigned rchiodo and joyceerhl and unassigned rchiodo Sep 10, 2020
@rchiodo
Copy link
Contributor

rchiodo commented Sep 10, 2020

@joyceerhl the work for this that I started on was here:
https://github.com/microsoft/vscode-python/tree/rchiodo/native_jupyter_support

@rchiodo
Copy link
Contributor

rchiodo commented Sep 10, 2020

Actually specifically this commit:
microsoft/vscode-python@9cb0b66

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@DonJayamanne
Copy link
Contributor Author

Closing in favour of #254

@DonJayamanne
Copy link
Contributor Author

Oops, closed the wrong issue here

@DonJayamanne DonJayamanne reopened this Jan 20, 2021
@DonJayamanne DonJayamanne mentioned this issue Jan 20, 2021
Merged
@DonJayamanne
Copy link
Contributor Author

Most of it has been supported, just added some tests

@rchiodo
Copy link
Contributor

rchiodo commented Jan 23, 2021

Validated. Used

"jupyter.disableZMQSupport": true

to test

@rchiodo rchiodo closed this as completed Jan 23, 2021
This was referenced Mar 8, 2021
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DonJayamanne @greazer @rchiodo @joyceerhl