Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multidimensional data in data viewer #298

Closed
joyceerhl opened this issue Oct 26, 2020 · 2 comments
Closed

Add support for multidimensional data in data viewer #298

joyceerhl opened this issue Oct 26, 2020 · 2 comments
Assignees

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented Oct 26, 2020

  • Modify vscodeGetDataFrameRows to convert extra dimensions to strings
  • Truncate long values UI side
  • When user clicks into a cell, display the full flattened element
@joyceerhl
Copy link
Contributor Author

joyceerhl commented Jan 27, 2021

To validate this one please open manualTestFile.py and verify that you can open myTensor in the data viewer via the following avenues (all of the following should work):

  1. Variable view
  2. Debugging cell in interactive window
  3. Debug current Python file --> debug variables panel --> View Variable in Data Viewer

Initially, data >7 characters in length should be displayed with an ellipsis truncating the overflowing text. When you resize the columns the columns should update to show more of the data. When you click into a cell you should be able to scroll horizontally to view the full value with the left and right arrows, but the cell should be readonly--you should not be able to enter any keys and have them update the cell content.

Please also validate that you can open ragged numpy arrays and tensors (i.e. where the 2nd or 3rd dimensions have a variable number of elements between rows)

@rchiodo
Copy link
Contributor

rchiodo commented Feb 9, 2021

Validated

@rchiodo rchiodo closed this as completed Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants