-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native Notebooks - Stop execution (cell and kernel level) don't work #4369
Comments
@claudiaregio please could you provide a sample code to replicate this issue. Also, please confirm this is not an issue when you try the same in classic Jupyter (browser). |
This is expected (as evidenced here:) However we can make native notebooks automatically restart if they take too long like we do for the old editor. I'll also add more logging to make sure we're interrupting if this comes up again. |
Looks like this belongs in validate. |
I couldn't replicate the original issue, hence leaving for someone else to validate. |
To repro you have to run with debug bits and uninstall the json rpc stuff. Then the extra layer for interrupt doesn't work. |
I have had all diary study participants mention this same behavior so far and had it happen again during a wrap up interview. Can pull the footage to share on Monday. |
Joyce, it looks you just validated it. That's the intended behavior when the interrrupt fails. Jupyter is not guaranteed to interrupt so we ask for a restart if it doesn't work. |
For me this always happens with a sleep if you don't have the json rpc library installed (dev bits). But it can happen for other code as well. See the ipython bug: |
Oh, good. Closing as validated then :) |
Nothing happens, have to close and reopen the notebook
The text was updated successfully, but these errors were encountered: