Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Notebooks - Stop execution (cell and kernel level) don't work #4369

Closed
claudiaregio opened this issue Jan 13, 2021 · 10 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@claudiaregio
Copy link
Contributor

  1. Run any long running cell
  2. Try to stop the execution (either at the cell level or notebook kernel level)

Nothing happens, have to close and reopen the notebook

@claudiaregio claudiaregio added bug Issue identified by VS Code Team member as probable bug internal contributor labels Jan 13, 2021
@DonJayamanne
Copy link
Contributor

@claudiaregio please could you provide a sample code to replicate this issue.
If possible, try to provide a simple sample so we can test/setup easily at our end.

Also, please confirm this is not an issue when you try the same in classic Jupyter (browser).

@DonJayamanne DonJayamanne added the info-needed Issue requires more information from poster label Jan 13, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Jan 14, 2021

This is expected (as evidenced here:)
ipython/ipython#3400

However we can make native notebooks automatically restart if they take too long like we do for the old editor.

I'll also add more logging to make sure we're interrupting if this comes up again.

@greazer
Copy link
Member

greazer commented Jan 20, 2021

Looks like this belongs in validate.

@greazer greazer removed the info-needed Issue requires more information from poster label Jan 20, 2021
@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jan 22, 2021

I couldn't replicate the original issue, hence leaving for someone else to validate.
I think testing on windows is best as Rich was able to repro on windows.

@rchiodo
Copy link
Contributor

rchiodo commented Jan 22, 2021

To repro you have to run with debug bits and uninstall the json rpc stuff. Then the extra layer for interrupt doesn't work.

@claudiaregio
Copy link
Contributor Author

I have had all diary study participants mention this same behavior so far and had it happen again during a wrap up interview. Can pull the footage to share on Monday.

@joyceerhl
Copy link
Contributor

This is still a problem at least on Windows

image

image

@rchiodo
Copy link
Contributor

rchiodo commented Jan 28, 2021

Joyce, it looks you just validated it. That's the intended behavior when the interrrupt fails. Jupyter is not guaranteed to interrupt so we ask for a restart if it doesn't work.

@rchiodo
Copy link
Contributor

rchiodo commented Jan 28, 2021

For me this always happens with a sleep if you don't have the json rpc library installed (dev bits). But it can happen for other code as well. See the ipython bug:
ipython/ipython#3400

@joyceerhl
Copy link
Contributor

Oh, good. Closing as validated then :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

5 participants