-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export the ipynb to a directory outside of the current workspace, there wasn't any python code prompt at the start to change directory to the previous location of the .ipynb file. #4419
Comments
@zhouwangyang Thanks for filing. Confirmed I'm not seeing the directory change on import. |
@IanMatthewHuff I was just debugging this. Provided that the python file we're running from is in the current workspace, this is working for me:
Exporting and then opening in editor, I am also seeing this, not sure if this is what we are expecting to see?: |
Regression perhaps, but we're unclear as to whether this needs to be fixed at all. We should change the test plan. |
@zhouwangyang please reopen and provide any clarification if you're still seeing a problem. |
I still repro this. But doesn't seem worthy of Sept consideration. |
@IanMatthewHuff mentioned he could repro, as nothing has been done to fix this, I"m re-opening this issue. |
When trying to reproduce this and looking at the code, it seems like all the limitations are by design: It would be a good idea to clarify the nbconvert limitation in the setting's description. |
This feature has a few issues: the path format is broken for Windows, the path is incorrect for importing/exporting notebooks, and it's not implemented in non-nbconvert code-paths. |
Environment data
Version: 1.53.0-insider (user setup)
Commit: eaa959d34b863dec932077d94daece22504a396b
Date: 2021-01-18T05:13:25.733Z
Electron: 11.2.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 10.0.17134
anaconda: python 3.8.5(64 bit)
Build of python-insider: 2020.12.414227025
Build of Jupyter-insider: 2021.1.481581316-rc
Expected behaviour
1.Open the file in the browser, should get an initial cell added to change directory back to your workspace directory.
2.Open the file in the editor. There should be python code at the start to change directory to the previous location of the .ipynb file
Actual behaviour
Steps to reproduce:
4.Open the file in the editor. There should be python code at the start to change directory to the previous location of the .ipynb file
The text was updated successfully, but these errors were encountered: