Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of Icons in Native Notebook toolbar is odd #4632

Closed
DonJayamanne opened this issue Feb 3, 2021 · 8 comments
Closed

Order of Icons in Native Notebook toolbar is odd #4632

DonJayamanne opened this issue Feb 3, 2021 · 8 comments
Labels
upstream-vscode Blocked on upstream VS code

Comments

@DonJayamanne
Copy link
Contributor

Screen Shot 2021-02-03 at 13 07 20

What is the expected order of icons

  1. Run All (added by vs code, when running all, this changes to Stop)
    Screen Shot 2021-02-03 at 13 13 28

  2. Clear output (added by VS Code)
    Screen Shot 2021-02-03 at 13 13 31

  3. Interrupt Kernel (added by us)
    Enabled only when cells are running (kernel is busy)
    Screen Shot 2021-02-03 at 13 13 33

  4. Open Changes (added by VS Code - no idea why this is after our icon?)
    Screen Shot 2021-02-03 at 13 13 36

  5. Restart Kernel
    Enabled only when cells are running (kernel is busy)
    Screen Shot 2021-02-03 at 13 13 39

  6. Run Cell Above
    Enabled only when any cell other than 1st is selected
    Screen Shot 2021-02-03 at 13 13 42

  7. Run cell & below
    Screen Shot 2021-02-03 at 13 13 44

  8. Variable viewer
    Screen Shot 2021-02-03 at 13 13 47

  9. Export Notebook
    Screen Shot 2021-02-03 at 13 13 50

  10. Trust Icon (Red when not trusted, & green when trusted)
    Screen Shot 2021-02-03 at 13 13 53

  11. Specify Local or remote (used to toggle between local or remote jupyter connections)
    Screen Shot 2021-02-03 at 13 13 56

  12. Last (split editor) Added by VS Code
    Screen Shot 2021-02-03 at 13 13 59
@DonJayamanne
Copy link
Contributor Author

Not sure where Run Above, Run Below should be? Should the be placed before or after interrupt and restart?
Feels like they should be next to run all. & clear output, interrupt & restart should be placed together.
Followed by Variable viewer as thats the next logical icon to be used.
Lastly are export, trust, select local/remote..

@joyceerhl
Copy link
Contributor

@claudiaregio had me file this related bug on vscode: microsoft/vscode#114927

@greazer
Copy link
Member

greazer commented Feb 3, 2021

Unless we have good reason to change it (one reason may be VS Code limitations), it should remain the same as webview had it:
image

If we cannot mimic what we had due to VS Code limitations we can file a bug on them.

@greazer greazer changed the title Order of Icons in Native Notebooks Order of Icons in Native Notebook toolbar is odd Feb 3, 2021
@DonJayamanne DonJayamanne added blocked upstream-vscode Blocked on upstream VS code labels Feb 3, 2021
@DonJayamanne
Copy link
Contributor Author

Until the VSC issue is resolved, this is the best we can do today.
Moving issue to blocked upstream.

Screen Shot 2021-02-03 at 13 36 08

@DonJayamanne DonJayamanne mentioned this issue Feb 3, 2021
Merged
@IanMatthewHuff IanMatthewHuff mentioned this issue Feb 4, 2021
Merged
9 tasks
@rebornix
Copy link
Member

@claudiaregio had me file this related bug on vscode: microsoft/vscode#114927

Please see comment microsoft/vscode#114927 (comment), (group 1_run in the editor toolbar is replaced with submenu editor/title/run). It seems that Jupyter extension already updates the group to navigation for these commands.

@DonJayamanne
Copy link
Contributor Author

Waiting on VS Code to provide detail on guidelines for these buttons (lots of changes happening in this space, toolbar, editor/title/run support in notebooks, etc)

@DonJayamanne
Copy link
Contributor Author

Validate

@joyceerhl
Copy link
Contributor

Validating as I believe our current toolbar is what we expect:

image

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
upstream-vscode Blocked on upstream VS code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rebornix @DonJayamanne @greazer @joyceerhl