Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getActiveInterpreter can take a long time. #5004

Closed
rchiodo opened this issue Mar 2, 2021 · 4 comments
Closed

getActiveInterpreter can take a long time. #5004

rchiodo opened this issue Mar 2, 2021 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Mar 2, 2021

We should cache this value.
Or ask the python team why this isn't cached.

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Mar 2, 2021
@rchiodo
Copy link
Contributor Author

rchiodo commented Mar 2, 2021

If we cache, we should update when they get their new value.

@IanMatthewHuff
Copy link
Member

Not sure if we have a clear customer validation here, but I see the code changes for this. Validating.

@rchiodo
Copy link
Contributor Author

rchiodo commented Mar 22, 2021

Sorry should have added validation steps.

The delay was apparent when opening new notebooks. The kernel picker would take 5 seconds to even appear. All of this time was spent searching for the active interpreter on my own machine.

@IanMatthewHuff
Copy link
Member

Yeah, I do see it being a bit snappier than before. I don't have exact numbers, but seems to be an improvement.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants