Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for GoTo Definition #5125

Closed
IanMatthewHuff opened this issue Mar 11, 2021 · 0 comments · Fixed by #8908
Closed

Tests for GoTo Definition #5125

IanMatthewHuff opened this issue Mar 11, 2021 · 0 comments · Fixed by #8908
Assignees
@rchiodo
Labels
debt Code quality issues
Milestone
February 2022

Comments

@IanMatthewHuff
Copy link
Member

We should have tests for GoTo Definition functionality.

In particular we need tests for the following:

  1. Jumping between notebook cells. Define foo in cell 1 then use it in cell 2. Make sure F12 works. This tests our concat doc converting.
  2. Jumping outside of notebook cells to python code. This is what was broken in Go to definition does not work for Pandas and other libraries #4972.
@greazer greazer added this to the April 2021 Release milestone Mar 24, 2021
@greazer greazer modified the milestones: April 2021 Release, May 2021 Release Apr 1, 2021
@DavidKutu DavidKutu self-assigned this May 5, 2021
@greazer greazer modified the milestones: May 2021 Release, June 2021 Release May 6, 2021
@DavidKutu DavidKutu mentioned this issue May 18, 2021
Closed
9 tasks
@greazer greazer modified the milestones: June 2021 Release, June 2021 Engineering Only Jun 3, 2021
@DavidKutu DavidKutu removed their assignment Jul 8, 2021
@greazer greazer added debt Code quality issues engineering labels Aug 2, 2021
@rchiodo rchiodo self-assigned this Oct 18, 2021
@rchiodo rchiodo added this to the October 2021 milestone Oct 18, 2021
@rchiodo rchiodo removed their assignment Oct 27, 2021
@rchiodo rchiodo modified the milestones: October 2021, November 2021 Oct 27, 2021
@rchiodo rchiodo modified the milestones: November 2021, January 2022 Dec 6, 2021
@rchiodo rchiodo modified the milestones: January 2022, February 2022 Jan 27, 2022
@rchiodo rchiodo self-assigned this Feb 1, 2022
@rchiodo rchiodo mentioned this issue Feb 2, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rchiodo rchiodo

Labels
debt Code quality issues
Projects
None yet
Milestone
February 2022
Development

Successfully merging a pull request may close this issue.

Add goto definition test for notebooks microsoft/vscode-jupyter
5 participants
@IanMatthewHuff @DonJayamanne @greazer @rchiodo @DavidKutu