Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synapse: Default kernel name is not provide and preventing synapse from working #5290

Closed
rchiodo opened this issue Mar 25, 2021 · 3 comments
Closed

Synapse: Default kernel name is not provide and preventing synapse from working #5290

rchiodo opened this issue Mar 25, 2021 · 3 comments
Assignees
@joyceerhl
Labels
bug Issue identified by VS Code Team member as probable bug partner

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Mar 25, 2021

The kernelconnection we pass on remote should not default to an empty name. This can prevent the server from starting a kernel as not all server realize an empty name is the default kernel.
@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Mar 25, 2021
@rchiodo
Copy link
Contributor Author

rchiodo commented Mar 25, 2021

We should be able to enumerate the remote kernel specs to get the 'default' one.

@greazer greazer added this to the May 2021 Release milestone Apr 1, 2021
@joyceerhl joyceerhl self-assigned this Apr 26, 2021
@joyceerhl joyceerhl mentioned this issue Apr 27, 2021
Merged
9 tasks
@IanMatthewHuff
Copy link
Member

@joyceerhl Any particular validation here? If it worked for synapse I'm fine to just validate on that, and I can see the code change.

@rchiodo rchiodo removed this from the May 2021 Release milestone May 27, 2021
@IanMatthewHuff
Copy link
Member

Validated. Just reopen if there is still an issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joyceerhl joyceerhl

Labels
bug Issue identified by VS Code Team member as probable bug partner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@IanMatthewHuff @greazer @rchiodo @joyceerhl