Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure playwright and canvas are setup as optional dependencies #5567

Closed
DonJayamanne opened this issue Apr 20, 2021 · 1 comment
Closed

Ensure playwright and canvas are setup as optional dependencies #5567

DonJayamanne opened this issue Apr 20, 2021 · 1 comment
Assignees
@DonJayamanne

Comments

@DonJayamanne
Copy link
Contributor

These are not required for builds nor deployment.
I'm on a Mac M1, and these don't install.
I don't need them either (I can work around not having them).

We need to make them optional so that npm ci completes successfully.
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Apr 20, 2021
@DonJayamanne DonJayamanne self-assigned this Apr 20, 2021
@DonJayamanne DonJayamanne mentioned this issue Apr 20, 2021
Merged
@greazer greazer added code-health and removed bug Issue identified by VS Code Team member as probable bug labels Apr 22, 2021
@joyceerhl
Copy link
Contributor

Validated.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DonJayamanne @greazer @joyceerhl