Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cell and bellow & Run cells above not working #5636

Closed
grudloff opened this issue Apr 26, 2021 · 11 comments
Closed

Run cell and bellow & Run cells above not working #5636

grudloff opened this issue Apr 26, 2021 · 11 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@grudloff
Copy link

Environment data

  • VS Code version: 1.56.0-insider
  • Jupyter Extension version: v2021.6.780948196
  • Python Extension version: v2021.5.756443519-dev
  • OS: Windows_NT x64 10.0.19041
  • Python and/or Anaconda version: Python 3.8.8 & conda 4.9.2
  • Type of virtual environment used: conda
  • Jupyter server running: Local

Nothing happens when I click 'Run cell and bellow' or 'Run cells above'. Jupyter output doesn't log any new entry when doing either but seems to be working fine when clicking the run all button, or running cell by cell with 'enter+shift' or the run cell button.

@grudloff grudloff added the bug Issue identified by VS Code Team member as probable bug label Apr 26, 2021
@joyceerhl
Copy link
Contributor

@grudloff If you first run a cell with shift+enter, then use the "run cell and below" button, does that work? "Run cell and below" isn't working for me either but I'd like to confirm that I'm seeing the same cause you're reporting. To me it looks like "Run cell and below" and "Run cells above" will not work if there's no active kernel for the current active notebook at the time that the command is invoked.

image

Instead I believe we'd want to start the kernel if one hasn't already started when "Run cell and below" or "Run cells above" are invoked. Though this is also likely happening because I don't believe we're autostarting kernels anymore after the latest notebook API changes landed.

@grudloff
Copy link
Author

In my case, it doesn't work even when a cell has been run before and the kernel is already started.

@grudloff
Copy link
Author

Doing the same in native jupyter notebook under the same environment works as expected without any issue.

@DonJayamanne
Copy link
Contributor

@joyceerhl the fix is pretty simple we need to call getOrCreate instead of get.

@rchiodo rchiodo added this to the May 2021 Release milestone Apr 29, 2021
@joyceerhl joyceerhl self-assigned this Apr 30, 2021
@joyceerhl
Copy link
Contributor

Validated. Run cell and below and Run cells above are working in the latest VSIX off the release branch.

@joyceerhl joyceerhl removed their assignment Apr 30, 2021
@grudloff
Copy link
Author

grudloff commented May 2, 2021

Seems my problem was unrelated. I am still experiencing the same issue.

@joyceerhl
Copy link
Contributor

@grudloff This fix will become available in the next release that we publish. Can you try this temporary VSIX out (should already contain the fix) and let us know if the problem persists? https://github.com/microsoft/vscode-jupyter/suites/2626147023/artifacts/57578598

@grudloff
Copy link
Author

grudloff commented May 4, 2021

Hello @joyceerhl. Thanks for the help but sadly the issue still remains.

@grudloff
Copy link
Author

grudloff commented May 10, 2021

It seems the Run cell and bellow & Run cells above was added on the last version (I don't remember seeing those in the insiders version at least) and for some reason using the buttons works perfectly for me but doing the same through right-clicking or selecting the "..." and then selecting either option is still doing nothing.

@joyceerhl
Copy link
Contributor

Are you encountering issues in VS Code Stable? There are still a few problems we're working through re run cell and below, some of which depend on upstream fixes in VS Code: #5737 #5766

@grudloff
Copy link
Author

Normal VS Code was working fine for me.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

5 participants
@DonJayamanne @grudloff @rchiodo @joyceerhl and others