Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter extension should wait until a document is opened to fetch kernels in remote scenarios #5846

Closed
DonJayamanne opened this issue May 11, 2021 · 3 comments
Assignees

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented May 11, 2021

  • Fetching kernels is slow
  • Kernels are required for Interactive & Notebooks

Hence makes sense to fetch kernels as soon as extension activates
This way kernels are available (already being fetched) as soon as a notebook is opened

Things to consider:

  • Local vs remote
  • Delays displaying kernels (hence run button) when opening a notebook
    • The longer it takes to fetch these, the longer the Run button is hidden
  • If usinvg remote connection
    • & user opens a Python file, what will happen? will user get error about kernels?
@DonJayamanne
Copy link
Contributor Author

@IanMatthewHuff /cc

I think what we do today is good (correct thing), but lets see if there are any drawbacks (or things that need to be fine tuned or other)

@IanMatthewHuff
Copy link
Member

Yeah, it would be good to talk over. Having been working on fixing up tests the main cause of test breakage was the change from loading kernels at document open time to activation time. Feels right at activation time to me, but I do feel some oddness, especially for stuff like remote scenarios.

@greazer greazer changed the title Should jupyter extension wait until a document is opened to fetch kernels Jupyter extension should wait until a document is opened to fetch kernels in remote scenarios May 13, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Jun 2, 2021

Validated

@rchiodo rchiodo closed this as completed Jun 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants