Method completions inserting double values when selected

[SiddhanthUnnithan]

I'm currently working in a native notebook editor on my local VS Code.

I have my Python language server set to "None" (not using Pylance or Jedi), and am seeing the following for completions:

When choosing the completion I see the following:

Instead of just inserting "get_image_details" the Notebook editor inserts "env.get_image_details". I'd expect only the method from the completion to be inserted when selected.

[claudiaregio]

Have to discuss if this is worth fixing since this is why we recommend language servers

[rchiodo]

Somehow the text edits from Jupyter aren't working in latest VS code.

I'm guessing this doesn't repro in the interactive window.

[greazer]

It does not repro in the IW. However, it seems likely that people who set the LS to none is a small number. Therefore, moving out of upcoming milestone.

[jiewangjs]

Any feedback on the problem ?

[rchiodo]

It does not repro in the IW. However, it seems likely that people who set the LS to none is a small number. Therefore, moving out of upcoming milestone.

This repros with pylance. It doesnt' require ls set to none.

[jiewangjs]

@rchiodo Yep, I figured it out. Disabled pylance, and problem solved.

[roblourens]

Was anything changed here? What needs verification?

[SiddhanthUnnithan]

@DonJayamanne just want to confirm that with the changes you merged @jiewangjs will no longer need to disable Pylance to avoid seeing double values?

[claudiaregio]

@SiddhanthUnnithan I believe the completions were actually coming from Jupyter, we merge both Pylance and Jupyter returned ones. This wasn't a Pylance issue so @jiewangjs shouldn't need to disable Pylance for Don's fixes to be seen