Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webview notebook editor code #6488

Closed
1 task done
joyceerhl opened this issue Jul 1, 2021 · 2 comments
Closed
1 task done

Remove webview notebook editor code #6488

joyceerhl opened this issue Jul 1, 2021 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues verified Verification succeeded
Milestone

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented Jul 1, 2021

(WIP)

  • Delete interactiveWindow.ts, interactiveWindowProvider.ts, interactiveWindowCommandListener.ts, interactiveBase.ts
@joyceerhl
Copy link
Contributor Author

Discussion with @rebornix @rchiodo @DonJayamanne

This iteration (Stage 0)

  • Remove Live Share layers

Stage 1
Remove the UI
Remove the INotebookEditorProvider
Remove INotebook (TBD? Native notebooks codepath also depends on INotebook)

Stage 2
Remove the ICell interface

  • Rewrite export
  • Remove INotebookExecutionLogger preExecute and postExecute in favor of nativePostExecute (take NotebookCell instead of ICell)
    How do we refactor execution so that things can be shared
    What are we going to do for other languages
    Jupyter ext/Python ext --> npm module

Split out npm modules for

  • Kernel discovery (trivial, look on disk? Need Python to discover certain kernels)
  • Open sockets and start kernels
  • Translating Jupyter outputs to VS Code outputs

--- Interactive window discussion ---

We need to be able to execute code silently against the underlying kernel so we cannot use pure VS Code APIs to execute code in the interactive window

  • CWD
  • file

Interactive window debug cell

  • INotebookExecutionLoggers provide cell hashes and increment execution count, must preserve loggers for native interactive window port

@joyceerhl joyceerhl added the debt Code quality issues label Jul 23, 2021
@greazer greazer changed the title Cleanup old webview code Remove webview code Aug 2, 2021
@greazer greazer changed the title Remove webview code Remove webview notebook code Aug 2, 2021
@greazer greazer changed the title Remove webview notebook code Remove webview notebook editor code Aug 2, 2021
@greazer greazer added this to the August 2021 milestone Aug 5, 2021
@greazer greazer removed this from the August 2021 milestone Aug 9, 2021
@greazer greazer added this to the August 2021 milestone Aug 13, 2021
@DonJayamanne
Copy link
Contributor

Closing as this work has been completed

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2021
@DonJayamanne DonJayamanne added the verified Verification succeeded label Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants