Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks - Variables explorer cleared when data-viewer is invoked from it and given focus. #7325

Closed
claudiaregio opened this issue Aug 28, 2021 · 2 comments · Fixed by #7838
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug variable-explorer verified Verification succeeded
Milestone

Comments

@claudiaregio
Copy link
Contributor

Environment data

  • VS Code version: 1.60.0
  • Jupyter Extension version: v2021.8.2031173646

Steps to reproduce:

  1. Open variable explorer
  2. Open dataframe in data viewer

Expected behavior

Variables are remain

Actual behavior

Variables are cleared

I know that this happens because the focus changes to the data viewer which is obviously not a notebook and therefore has no variables to show. However, I found this to be a really strange interaction. When wanting to open two dataframes back to back I thought it broke, took me a second to realize I had to go back to get focus on the notebook to go open the variable again.

@claudiaregio claudiaregio added the bug Issue identified by VS Code Team member as probable bug label Aug 28, 2021
@greazer greazer added variable-explorer papercut 🩸 Something affecting the productivity of the team and removed needs-triage labels Aug 30, 2021
@greazer greazer added this to the September 2021 milestone Aug 30, 2021
@greazer greazer removed the papercut 🩸 Something affecting the productivity of the team label Aug 30, 2021
@greazer greazer changed the title Notebooks - Variables clear after variable opened in data viewer Notebooks - Variables explorer cleared when data-viewer is invoked from it and given focus. Sep 23, 2021
@rchiodo rchiodo modified the milestones: September 2021, October 2021 Sep 28, 2021
@rchiodo rchiodo self-assigned this Oct 6, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Oct 6, 2021

I assume we're just going to make the variable viewer work when a data viewer is open?

@rchiodo
Copy link
Contributor

rchiodo commented Oct 6, 2021

Verification steps:

  • Open a notebook and a python file
  • From the notebook create a list or something that can be opened in the data frame viewer
  • Create another list with a different name
  • Open the data viewer for the first list
  • You should still see variables and you should still be able to open the second list
  • Switch back to the python file and verify the variables go away

@DonJayamanne DonJayamanne added the verified Verification succeeded label Oct 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug variable-explorer verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants