Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntelliSense for data files does not work on subfolders #7816

Closed
miguelsolorio opened this issue Oct 5, 2021 · 6 comments · Fixed by #8792
Closed

IntelliSense for data files does not work on subfolders #7816

miguelsolorio opened this issue Oct 5, 2021 · 6 comments · Fixed by #8792
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-intellisense Intellisense & other language features in notebook cells for any language verified Verification succeeded
Milestone

Comments

@miguelsolorio
Copy link

When trying to read data files via df = pd.read_csv(), it appears that intellisense does not show subfolders and I have to explicitly trigger intellisense again after there are no matches. It would be nice if I didn't have to explicitly trigger this and it just worked automatically.

CleanShot.2021-10-05.at.09.58.01.mp4
@miguelsolorio miguelsolorio added the bug Issue identified by VS Code Team member as probable bug label Oct 5, 2021
@IanMatthewHuff IanMatthewHuff removed their assignment Oct 6, 2021
@IanMatthewHuff
Copy link
Member

Reproed this myself as well with the exact same issue (csv files in a data sub-directory).

@greazer greazer added the notebook-intellisense Intellisense & other language features in notebook cells for any language label Oct 11, 2021
@greazer greazer added this to the October 2021 milestone Oct 11, 2021
@rchiodo rchiodo modified the milestones: October 2021, November 2021 Oct 27, 2021
@rchiodo rchiodo self-assigned this Oct 27, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Oct 27, 2021

Would have to debug jupyter intellisense for this. Pylance doesn't provide this data.

@rchiodo
Copy link
Contributor

rchiodo commented Nov 11, 2021

This PR will partially resolve this:
#8247
if you add ' or " to your trigger list.

However after you hit tab on say "./data/, you have to use ctrl+space again (or delete the last /) to get the completions to come up again. Not sure how to get VS code to do autocompletions again when just typing? Maybe delete the final / on the end when inserting the text so the user has to hit / again? (/ becomes a trigger character automatically when strings cause completions)

@rchiodo
Copy link
Contributor

rchiodo commented Nov 11, 2021

stringCompletion

@rebornix @misolori do you have any suggestions on how to get the secondary directories to work?

@miguelsolorio
Copy link
Author

miguelsolorio commented Nov 15, 2021

We use intellisense for paths in HTML where the suggest widget doesn't go away, which look like files as opposed to intellisense suggestions (notice the file icons vs symbol icons in your gif)

CleanShot.2021-11-15.at.09.28.46.mp4

@rchiodo
Copy link
Contributor

rchiodo commented Nov 15, 2021

Thanks. I can look at how the html extension does it. Might be the 'tab' key is a trigger character too.

@rchiodo rchiodo modified the milestones: November 2021, January 2022 Dec 1, 2021
@hediet hediet added the verified Verification succeeded label Jan 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-intellisense Intellisense & other language features in notebook cells for any language verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants