Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipywidgets performance can be slow whe used over a network #7965

Closed
sdissegna-maystreet opened this issue Oct 19, 2021 · 1 comment
Closed
Assignees
Labels
debt Code quality issues ipywidgets Rendering, loading, saving, anything to do with IPyWidgets perf Performance issues verified Verification succeeded
Milestone

Comments

@sdissegna-maystreet
Copy link
Contributor

This is very noticeable in projects such as https://github.com/cdr/code-server. The synchronization forces ipywidgets to wait for a browser-server round trip before sending the next message.

Environment data

  • VS Code version: https://github.com/cdr/code-server latest (it's likely to happen in other environments such as gitpod or codespaces)
  • Jupyter Extension version (available under the Extensions sidebar): master
  • Python Extension version (available under the Extensions sidebar): v2021.10.1336267007
  • OS (Windows | Mac | Linux distro) and version: macOS 10.15
  • Python and/or Anaconda version: 3.9
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
  • Jupyter server running: Local

Expected behaviour

Performance is acceptable over a network.

Actual behaviour

10-20 widgets are enough to make a cell take many seconds to render the widgets

Steps to reproduce:

import ipywidgets as w
children = [w.Button() for _ in range(0, 100)]
w.HBox(children=children)
@sdissegna-maystreet sdissegna-maystreet added the bug Issue identified by VS Code Team member as probable bug label Oct 19, 2021
@rchiodo rchiodo removed their assignment Oct 19, 2021
@greazer greazer added ipywidgets Rendering, loading, saving, anything to do with IPyWidgets and removed needs-triage labels Oct 21, 2021
@greazer greazer added this to the October 2021 milestone Oct 21, 2021
@DonJayamanne DonJayamanne added debt Code quality issues engineering perf Performance issues and removed bug Issue identified by VS Code Team member as probable bug labels Oct 21, 2021
@rchiodo rchiodo added the verified Verification succeeded label Nov 1, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Nov 1, 2021

/verified

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues ipywidgets Rendering, loading, saving, anything to do with IPyWidgets perf Performance issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants