-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify SelectJupyterURI to allow URI parameter #8918
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
reviewed
Feb 3, 2022
rchiodo
reviewed
Feb 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #8918 +/- ##
======================================
- Coverage 71% 70% -2%
======================================
Files 382 382
Lines 24750 24391 -359
Branches 3826 3850 +24
======================================
- Hits 17718 17204 -514
- Misses 5503 5663 +160
+ Partials 1529 1524 -5
|
rchiodo
approved these changes
Feb 3, 2022
rchiodo
reviewed
Feb 3, 2022
You should fix the linter problems. The other tests failing are a known issue and not caused by your change. You can ignore those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8902
Made the change to allow a bool and URI to be passed to command
jupyter.selectjupyteruri
. If source is aUri
it sets the serverSelector to the remote uri provided by the user.I added the bool mostly because it seemed like that was what it was originally setup to do. But the arg was unused because
this.serverSelector.selectJupyterURI(true, source),
hadtrue
hardcoded. It might not be necessary but it does allow someone to calljupyter.selectjupyteruri
and have their selector not include local options.I also added a test for this case in the commands unit test for the serverSelector.
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed). N/A