Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using Jupyter (instead of raw kernels) create Kernelspecs in a custom directory #9141

Closed
DonJayamanne opened this issue Feb 28, 2022 · 3 comments · Fixed by #9249
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Feb 28, 2022

Today we create the kernelspec json files in the global known Jupyter kernels directory.
This causes a few issues:

If we create kernelspecs in a custom directory that user isn't aware of:

  • We know that these are created by us
  • These need not EVER be displayed in the kernel picker
  • We can blow these away anytime as we don't have to worry about users editing them

Solution

  • Create these in a folder specific to the extension version (i.e. within the extension directory)
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Feb 28, 2022
@DonJayamanne DonJayamanne self-assigned this Feb 28, 2022
@DonJayamanne DonJayamanne added kernel-enumeration notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) and removed needs-triage labels Feb 28, 2022
@DonJayamanne DonJayamanne added this to the March 2022 milestone Feb 28, 2022
@rebornix rebornix added the verification-steps-needed Steps to verify are needed for verification label Mar 25, 2022
@rebornix
Copy link
Member

@DonJayamanne can you please provide detailed steps of what to test?

@rchiodo
Copy link
Contributor

rchiodo commented Mar 25, 2022

I believe this is a dupe of another. I already verified the kernelspecs are created in the temp folder under the extension.

@rchiodo rchiodo added the verified Verification succeeded label Mar 25, 2022
@rchiodo
Copy link
Contributor

rchiodo commented Mar 25, 2022

Duh the dupe is in this issue. THe one I verified earlier:
#5494

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants