Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: maven command history #87

Merged
merged 3 commits into from
Jul 18, 2018
Merged

refactor: maven command history #87

merged 3 commits into from
Jul 18, 2018

Conversation

Eskibear
Copy link
Member

  1. maven history commands are cached for each project in path.join(os.tmpdir(), EXTENSION_NAME, md5(pomXmlFilePath), "commandHistory.json");
  2. The content is of the schema, command itself is used as key.
{
    pomPath: "<absolutePath>", 
    timestamps: { 
        "commandA":  <timestamp>,
        "commandB":  <timestamp>,
         .......
    }    
}

@Eskibear Eskibear added this to the 1.0.0 milestone Jul 17, 2018
@Eskibear Eskibear self-assigned this Jul 17, 2018
@Eskibear Eskibear requested a review from jdneo July 17, 2018 13:41
jdneo
jdneo reviewed Jul 18, 2018
View reviewed changes
src/Utils.ts Outdated
try {
historyObject = JSON.parse(content);
historyObject.pomPath = pomPath;
historyObject.timestamps[command] = Date.now();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line?

jdneo
jdneo previously approved these changes Jul 18, 2018
View reviewed changes
@Eskibear Eskibear merged commit 5418932 into microsoft:master Jul 18, 2018
@Eskibear Eskibear deleted the pr_hist branch July 18, 2018 02:27
@Eskibear Eskibear mentioned this pull request Jul 18, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo approved these changes

Assignees

@Eskibear Eskibear

Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Eskibear @jdneo