-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full stack functional tests for RawKernel #2112
Comments
What we would probably need here is a class that returns back sequences of jupyter messages to create a mock JMP connection in the case where we are not in a rolling build. This would probably be quite similar to the lower levels of the current mock jupyter session that we use in testing. |
Some of this is done. To finish, change the default when running functional tests to be the raw kernel. |
Note for validation. This doesn't encompass creating a new mock raw layer. Just moves over the nightly full python functional tests to use raw as the default. |
Tests seem to be passing (although we still seem to have failures). |
I've tried to keep up with unit tests with all the submissions, but can't really add full stack functional tests until we are routed up to the end. Since we have both the old code path and the new kernels we need to test both paths. We could also consider given that we own the Session / Kernel / Future layers now some functional tests that work on real ZMQ Kernels to exercise just those levels with some different scenarios.
The text was updated successfully, but these errors were encountered: