Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full stack functional tests for RawKernel #2112

Closed
IanMatthewHuff opened this issue Mar 25, 2020 · 4 comments
Closed

Full stack functional tests for RawKernel #2112

IanMatthewHuff opened this issue Mar 25, 2020 · 4 comments
Assignees

Comments

@IanMatthewHuff
Copy link
Member

I've tried to keep up with unit tests with all the submissions, but can't really add full stack functional tests until we are routed up to the end. Since we have both the old code path and the new kernels we need to test both paths. We could also consider given that we own the Session / Kernel / Future layers now some functional tests that work on real ZMQ Kernels to exercise just those levels with some different scenarios.

@IanMatthewHuff
Copy link
Member Author

What we would probably need here is a class that returns back sequences of jupyter messages to create a mock JMP connection in the case where we are not in a rolling build. This would probably be quite similar to the lower levels of the current mock jupyter session that we use in testing.

@greazer
Copy link
Member

greazer commented Apr 29, 2020

Some of this is done. To finish, change the default when running functional tests to be the raw kernel.

@IanMatthewHuff IanMatthewHuff self-assigned this May 18, 2020
@IanMatthewHuff
Copy link
Member Author

Note for validation. This doesn't encompass creating a new mock raw layer. Just moves over the nightly full python functional tests to use raw as the default.

@rchiodo
Copy link
Contributor

rchiodo commented Aug 10, 2020

Tests seem to be passing (although we still seem to have failures).

@rchiodo rchiodo closed this as completed Aug 10, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants