Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal.external.osxExec not respected as debug terminal? #114

Closed
DonJayamanne opened this issue Nov 13, 2017 · 5 comments · Fixed by #249
Closed

terminal.external.osxExec not respected as debug terminal? #114

DonJayamanne opened this issue Nov 13, 2017 · 5 comments · Fixed by #249
Labels
area-debugging area-terminal bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@DonJayamanne
Copy link

From @rschindlauer on May 3, 2017 20:2

Environment data

VS Code version: 1.11.2
Python Extension version: 0.6.3
Python Version: 2.7.9
OS and version: macOS Sierra 10.12.4

Actual behavior

With terminal.external.osxExec set to /Applications/iTerm.app, the "External Terminal/Console" launch configuration still launches Terminal instead of iTerm.

Expected behavior

Launch iTerm as external debug terminal when terminal.external.osxExec is set to iTerm.

Steps to reproduce:

  • Add terminal.external.osxExec to user or workspace settings and set it to a terminal other than Terminal.
  • open a Python file
  • Debug with launch config External Terminal/Console

Settings

Your launch.json (if dealing with debugger issues):

{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Integrated Terminal/Console",
            "type": "python",
            "request": "launch",
            "stopOnEntry": true,
            "pythonPath": "${config.python.pythonPath}",
            "program": "${file}",
            "cwd": null,
            "console": "integratedTerminal",
            "env": null,
            "envFile": "${workspaceRoot}/.env",
            "debugOptions": [
                "WaitOnAbnormalExit",
                "WaitOnNormalExit"
            ]
        }
    ]
}

Your settings.json:

// Place your settings in this file to overwrite the default settings
{
    "editor.fontSize": 14,
    "terminal.integrated.shellArgs.osx": ["-l"],
    "editor.wordWrap": "on",
    "workbench.sideBar.location": "right",
    "workbench.colorTheme": "Visual Studio Dark",
    "window.zoomLevel": 0,
    "editor.renderWhitespace": "boundary",
    "editor.acceptSuggestionOnEnter": false,
    "python.linting.enabled": true,
    "python.linting.pylintArgs": [
        "--disable",
        "C0325,C0303"
    ],
    "sync.gist": "...",
    "sync.lastUpload": "2017-05-03T19:56:07.835Z",
    "sync.autoDownload": false,
    "sync.autoUpload": true,
    "sync.lastDownload": "2017-04-25T17:25:31.865Z",
    "sync.version": 262,
    "sync.showSummary": true,
    "sync.forceDownload": false,
    "sync.anonymousGist": false,
    "sync.host": "",
    "sync.pathPrefix": "",
    "workbench.iconTheme": "seti",
    "editor.snippetSuggestions": "top",
    "terminal.external.osxExec": "/Applications/iTerm.app",
    "rewrap.wrappingColumn": 78,
    "editor.rulers": [
        80
    ],
    "search.exclude": {
        "**/node_modules": true,
        "**/bower_components": true,
        "**/*_venv": true
    },
    "files.exclude": {
        "**/.git": true,
        "**/.svn": true,
        "**/.hg": true,
        "**/CVS": true,
        "**/.DS_Store": true,
        "**/.ipynb_checkpoints": true
    },
    "arduino.additionalUrls": [
        "https://lowpowerlab.github.io/MoteinoCore/package_LowPowerLab_index.json",
        "http://arduino.esp8266.com/stable/package_esp8266com_index.json"
    ]
}

Copied from original issue: DonJayamanne/pythonVSCode#932

@DonJayamanne
Copy link
Author

@rschindlauer Are you still experiencing this issue.
I do apologize for not getting back to you on this, I'd like to help you out here, please let me know if it still persists. Thanks.

@DonJayamanne
Copy link
Author

From @rschindlauer on October 6, 2017 20:34

Yes, I just tried it again and can confirm that Terminal opens, not iTerm (which I set terminal.external.osxExec to).

@DonJayamanne
Copy link
Author

Please change the following to externalTerminal

"console": "integratedTerminal",

@DonJayamanne
Copy link
Author

From @rschindlauer on October 6, 2017 23:52

I did, sorry about the misleading config in the original issue.

@DonJayamanne
Copy link
Author

Closing in favor of #250

@DonJayamanne DonJayamanne added this to the December 2017 milestone Nov 17, 2017
DonJayamanne added a commit that referenced this issue Nov 22, 2017
#249)

- Fixes #25, #32, #35, #235, #242 (unable to run without debugging using CTRL+F5)   
- Fixes #191, #158, #24, #136  (error message displayed when debugged code terminates)  
- Fixes #157 (debugger crashes when python program does not launch)
- Fixes #114, #149, #250 (use vscode infrastructure to launch debugger in integrated and external terminals)  
- Fixes #239 Remove prompt added to pause terminal upon program completion
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-debugging area-terminal bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants