Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dotenv to read env variables #1376

Closed
DonJayamanne opened this issue Apr 12, 2018 · 0 comments · Fixed by #1802
Closed

Use dotenv to read env variables #1376

DonJayamanne opened this issue Apr 12, 2018 · 0 comments · Fixed by #1802
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
June 2018

Comments

@DonJayamanne
Copy link

DonJayamanne commented Apr 12, 2018 •
edited by brettcannon
Loading

Currently we parse the .env file ourselves.
Drawback - we don't support multiline vars
Better to use a popular package such as dotenv that's supported and battle tested.
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Apr 12, 2018
@DonJayamanne DonJayamanne added this to the April 2018 milestone Apr 12, 2018
@brettcannon brettcannon modified the milestones: April 2018, May 2018 Apr 12, 2018
@DonJayamanne DonJayamanne mentioned this issue May 30, 2018
Merged
2 tasks
@brettcannon brettcannon modified the milestones: May 2018, June 2018 Jun 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
June 2018
Development

Successfully merging a pull request may close this issue.

Use dotenv package to parse environment variables definition files DonJayamanne/pythonVSCode
2 participants
@brettcannon @DonJayamanne