Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"test" is not an allowed value for the "request" property of launch configs configurations #15790

Closed
weinand opened this issue Mar 26, 2021 · 6 comments · Fixed by #16949
Closed
Assignees
Labels
area-debugging bug Issue identified by VS Code Team member as probable bug partner ask verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@weinand
Copy link

weinand commented Mar 26, 2021

The documentation at https://code.visualstudio.com/docs/python/testing#_debug-tests says that a value "test" can be used for the "request" property of launch configs configurations.

Please note, that this is neither supported by VS Code nor by DAP and it will break an unknown number of assumptions and result in a bad user experience (e.g. microsoft/vscode#119903). The only supported values are "launch" and "attach".

@weinand weinand added triage-needed Needs assignment to the proper sub-team bug Issue identified by VS Code Team member as probable bug labels Mar 26, 2021
@brettcannon
Copy link
Member

What would the preferred way be for us to be able to denote which launch configuration is meant to be used when debugging a test when launched from our test explorer?

@brettcannon brettcannon added info-needed Issue requires more information from poster partner ask labels Mar 26, 2021
@weinand
Copy link
Author

weinand commented Mar 26, 2021

@brettcannon you can either:

@brettcannon brettcannon removed the info-needed Issue requires more information from poster label Mar 26, 2021
@karthiknadig karthiknadig added area-debugging needs PR and removed triage-needed Needs assignment to the proper sub-team labels Mar 29, 2021
@karthiknadig karthiknadig added this to the August 2021 milestone Aug 12, 2021
@karthiknadig karthiknadig added the verification-steps-needed Steps to verify are needed for verification label Aug 19, 2021
@karthiknadig karthiknadig added the verification-needed Verification of issue is requested label Aug 20, 2021
@kimadeline
Copy link

Verification steps:

  1. Make sure you have "python.experiments.optInto": ["All"], in your user settings. If not, add it and reload.
  2. Open a workspace with some python files in it
  3. Add the following configuration to your launch.json file (create it first if necessary):
        {
            "name": "Some configuration",
            "type": "python",
            "request": "test",
            "console": "integratedTerminal"
        },
  1. Make sure that there's a squiggle under "test", and that the only accepted values are launch or attach

@kimadeline kimadeline removed the verification-steps-needed Steps to verify are needed for verification label Aug 20, 2021
@rzhao271
Copy link

rzhao271 commented Aug 24, 2021

I'm not seeing any squiggles on VS Code Insiders.

In my settings.json: "python.experiments.optInto": ["All"]
Python extension version: v2021.9.1160333636-dev

No squiggle

@rzhao271 rzhao271 reopened this Aug 24, 2021
@rzhao271 rzhao271 added the verification-found Issue verification failed label Aug 24, 2021
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Aug 24, 2021
@karthiknadig
Copy link
Member

@rzhao271
Copy link

I got it to work.
My launch config was invalid because it was just that block of JSON. When I created a new launch config, things got put into the proper format.

@rzhao271 rzhao271 added verified Verification succeeded and removed verification-found Issue verification failed labels Aug 24, 2021
@karthiknadig karthiknadig removed the triage-needed Needs assignment to the proper sub-team label Aug 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-debugging bug Issue identified by VS Code Team member as probable bug partner ask verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants