Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test-UI: Test welcome screen should not be shown when refreshing #16855

Closed
karthiknadig opened this issue Aug 3, 2021 · 0 comments · Fixed by #16906
Closed

Test-UI: Test welcome screen should not be shown when refreshing #16855

karthiknadig opened this issue Aug 3, 2021 · 0 comments · Fixed by #16906
Assignees
@karthiknadig
Labels
area-testing bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority regression Bug didn't exist in a previous release verified Verification succeeded
Milestone
August 2021

Comments

@karthiknadig
Copy link
Member

Currently when users do a refresh via the refresh button or running command from the command pallet. We force a refresh. Part of this is we remove all existing tests and start from scratch. While doing the clean up, once all tests are removed, it automatically triggers the welcome screen.

we need to set the context via when clause on the welcome screen to not show it if tests are discovered.
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug needs PR area-testing important Issue identified as high-priority labels Aug 3, 2021
@karthiknadig karthiknadig self-assigned this Aug 3, 2021
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Aug 3, 2021
@karthiknadig karthiknadig removed the triage-needed Needs assignment to the proper sub-team label Aug 3, 2021
@brettcannon brettcannon added the regression Bug didn't exist in a previous release label Aug 9, 2021
@karthiknadig karthiknadig mentioned this issue Aug 9, 2021
Merged
@karthiknadig karthiknadig added this to the August 2021 milestone Aug 9, 2021
@karthiknadig karthiknadig added the verified Verification succeeded label Aug 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karthiknadig karthiknadig

Labels
area-testing bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority regression Bug didn't exist in a previous release verified Verification succeeded
Projects
None yet
Milestone
August 2021
Development

Successfully merging a pull request may close this issue.

Fix for some bugs karthiknadig/vscode-python
2 participants
@brettcannon @karthiknadig