Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ILogger instead of console.error to reduce noise in unit tests #1821

Closed
DonJayamanne opened this issue May 31, 2018 · 0 comments · Fixed by #1820
Closed

Use ILogger instead of console.error to reduce noise in unit tests #1821

DonJayamanne opened this issue May 31, 2018 · 0 comments · Fixed by #1820
Assignees
@DonJayamanne
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
June 2018

Comments

@DonJayamanne
Copy link

We have errors being written out into console window when running tests.
This can be confusing when logging at the output.
@DonJayamanne DonJayamanne self-assigned this May 31, 2018
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels May 31, 2018
@DonJayamanne DonJayamanne mentioned this issue May 31, 2018
Merged
5 tasks
@brettcannon brettcannon added this to the June 2018 milestone Jun 5, 2018
DonJayamanne added a commit that referenced this issue Jun 5, 2018
@DonJayamanne
Log Conda not existing message as an information instead of an error (#…
4325ac1 
…1820)

Fixes #1817
Fixes #1821
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
June 2018
Development

Successfully merging a pull request may close this issue.

Log Conda not existing message as an information instead of an error DonJayamanne/pythonVSCode
2 participants
@brettcannon @DonJayamanne