Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we are not using --live-stream with conda run #18511

Closed
brettcannon opened this issue Feb 11, 2022 · 3 comments · Fixed by #18994
Closed

Make sure we are not using --live-stream with conda run #18511

brettcannon opened this issue Feb 11, 2022 · 3 comments · Fixed by #18994
Labels
area-editor-* User-facing catch-all area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2022

Comments

@brettcannon
Copy link
Member

Turns out to be redundant: conda/conda#11209 .
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Feb 11, 2022
@brettcannon brettcannon mentioned this issue Feb 11, 2022
Closed
@Harry-Hopkinson Harry-Hopkinson mentioned this issue Feb 13, 2022
Closed
@karrtikr
Copy link

Because conda/conda#11209 is yet to triaged, we should probably wait on this.

@karthiknadig karthiknadig self-assigned this Feb 14, 2022
@karthiknadig karthiknadig added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR area-debugging and removed triage-needed Needs assignment to the proper sub-team labels Feb 14, 2022
@karthiknadig karthiknadig removed their assignment Feb 14, 2022
@karthiknadig karthiknadig added area-editor-* User-facing catch-all and removed area-debugging labels Feb 14, 2022
@karrtikr karrtikr removed their assignment Feb 22, 2022
@karrtikr
Copy link

Unassigned myself as I'm not currently working on it.

@karrtikr karrtikr added the area-environments Features relating to handling interpreter environments label Feb 22, 2022
@brettcannon brettcannon mentioned this issue Apr 25, 2022
Merged
@karrtikr karrtikr added this to the April 2022 milestone Apr 25, 2022
@karrtikr karrtikr added the verification-needed Verification of issue is requested label Apr 25, 2022
@karrtikr
Copy link

Verification steps:

  • Use pre-release build of the extension
  • Select a conda environment
  • Check for conda run commands in the Python output panel
  • Ensure it doesn't use the --live-stream flag.

@joyceerhl joyceerhl added the verified Verification succeeded label May 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-editor-* User-facing catch-all area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2022
Development

Successfully merging a pull request may close this issue.

Stop using --live-stream with conda run brettcannon/vscode-python
4 participants
@brettcannon @karthiknadig @karrtikr @joyceerhl