Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift+Enter doesn't fully run code when last line of code is indented #2167

Closed
qubitron opened this issue Jul 16, 2018 · 3 comments · Fixed by #2222
Closed

Shift+Enter doesn't fully run code when last line of code is indented #2167

qubitron opened this issue Jul 16, 2018 · 3 comments · Fixed by #2222
Assignees
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority

Comments

@qubitron
Copy link

Environment data

  • VS Code version: 1.25.1
  • Extension version (available under the Extensions sidebar): 2018.7.0-beta
  • OS and version: macOS High Sierra
  • Python version (& distribution if applicable, e.g. Anaconda): 3.6.5
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
  • Relevant/affected Python packages and their versions: NA

Actual behavior

If the last line of code was indented, and you select multiple lines and press shift+enter, the indentation is left hanging in the console, even if you select a blank line/multiple blank lines to send

screen shot 2018-07-16 at 2 59 19 pm

screen shot 2018-07-16 at 2 59 25 pm

Expected behavior

If blank lines are selected, send them to the console so that the code runs without having to click in the console and press enter

Steps to reproduce:

Select code in an indented block, as shown above.

@ericsnowcurrently
Copy link
Member

I was able to verify this on linux.

@ericsnowcurrently
Copy link
Member

See #2222.

@brettcannon brettcannon added this to the Aug 2018 milestone Aug 2, 2018
@DonJayamanne DonJayamanne self-assigned this Aug 3, 2018
@brettcannon brettcannon modified the milestone: Aug 2018 Aug 13, 2018
@brettcannon brettcannon added important Issue identified as high-priority and removed P0 labels Aug 28, 2018
@brettcannon brettcannon modified the milestones: Aug 2018, Sep 2018 Aug 28, 2018
@DonJayamanne DonJayamanne reopened this Sep 17, 2018
@ericsnowcurrently
Copy link
Member

I've verified that this has been fixed.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants