Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap decoration of EventEmitter within a try...catch #2196

Closed
DonJayamanne opened this issue Jul 19, 2018 · 0 comments · Fixed by #2220
Closed

Wrap decoration of EventEmitter within a try...catch #2196

DonJayamanne opened this issue Jul 19, 2018 · 0 comments · Fixed by #2220
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@DonJayamanne
Copy link

If other extensions end up with code such as the following:

decorate(injectable(), EventEmitter);

Src - src/client/ioc/container.ts

Then the extension that loads second will crash.
Solution:

try {
	decorate(injectable(), EventEmitter);
} catch {}
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR labels Jul 19, 2018
@DonJayamanne DonJayamanne mentioned this issue Jul 21, 2018
Merged
4 tasks
DonJayamanne added a commit that referenced this issue Aug 1, 2018
@DonJayamanne
Decorate EventEmitter within a try..catch (#2220)
f01c810 
Fixes #2196
@lock lock bot locked as resolved and limited conversation to collaborators Aug 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decorate EventEmitter within a try..catch DonJayamanne/pythonVSCode
2 participants
@brettcannon @DonJayamanne