Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command 'python.buildWorkspaceSymbols' not found when "python.jediEnabled": false #2267

Closed
bob-white opened this issue Jul 27, 2018 · 3 comments · Fixed by #2419
Closed

command 'python.buildWorkspaceSymbols' not found when "python.jediEnabled": false #2267

bob-white opened this issue Jul 27, 2018 · 3 comments · Fixed by #2419
Assignees
@d3r3kk
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Milestone
Aug 2018

Comments

@bob-white
Copy link

bob-white commented Jul 27, 2018 •
edited
Loading

Environment data

  • VS Code version: 1.25.1
  • Extension version (available under the Extensions sidebar): 2018.7.1
  • OS and version: Windows 10
  • Python version (& distribution if applicable, e.g. Anaconda): Python 3.5
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
  • Relevant/affected Python packages and their versions: XXX

Actual behavior

Rebuilding workspace symbols fails to operate when python.jediEnabled is false.

Expected behavior

Rebuilding workspace symbols should work even when jedi is disabled.

Steps to reproduce:

  1. Disable Jedi.
  2. Attempt to rebuild workspace symbols.

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

Nothing actually makes it to the Python Log

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)

notificationsAlerts.ts:40 Error: command 'python.buildWorkspaceSymbols' not found
    at t._tryExecuteCommand (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:2915:36)
    at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:2914:846
    at Object.g [as _notify] (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:150:807)
    at Object.enter (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:154:85)
    at n.Class.derive._oncancel._run (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:155:896)
    at n.Class.derive._oncancel._completed (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:155:337)
    at l (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:158:855)
    at n.Class.derive.join.r.forEach.j.then.o.(anonymous function) (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:159:45)
    at Object.g [as _notify] (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:150:807)
    at Object.enter (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:154:85)
    at n.Class.derive._oncancel._run (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:155:896)
    at n.Class.derive._oncancel._completed (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:155:337)
    at l (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:158:855)
    at n.Class.derive.join.r.forEach.j.then.o.(anonymous function) (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:159:45)
    at Object.g [as _notify] (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:150:807)
    at Object.enter (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:154:85)
    at n.Class.derive._creator._run (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:155:896)
    at n.Class.derive._creator._completed (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:155:337)
    at Object.g [as _notify] (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:150:807)
    at Object.enter (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:154:85)
    at n.Class.derive._oncancel._run (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:155:896)
    at n.Class.derive._oncancel._completed (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:155:337)
    at e.resolveOk (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:3060:806)
    at e._receiveReply (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:3127:316)
    at e._receiveOneMessage (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:3126:609)
    at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:3125:424
    at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:3128:575
    at e.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:171:344)
    at c (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:302:1008)
    at Socket.<anonymous> (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:303:171)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:191:7)
    at readableAddChunk (_stream_readable.js:178:18)
    at Socket.Readable.push (_stream_readable.js:136:10)
    at Pipe.onread (net.js:560:20)```
@brettcannon brettcannon added bug Issue identified by VS Code Team member as probable bug area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs verification labels Jul 27, 2018
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. and removed needs verification labels Jul 30, 2018
@DonJayamanne DonJayamanne added this to the Aug 2018 milestone Jul 30, 2018
@DonJayamanne
Copy link

We need to include this command into the list of deprecated commands.
Just add command into src/client/common/featureDeprecationManager.ts

@brettcannon brettcannon added the important Issue identified as high-priority label Aug 2, 2018
@MikhailArkhipov
Copy link

Not LS specific, LS builds symbols continuously.

@d3r3kk d3r3kk self-assigned this Aug 15, 2018
d3r3kk added a commit to d3r3kk/vscode-python that referenced this issue Aug 21, 2018
@d3r3kk
Deprecate the 'Build Workspace Symbols' command.
e429a8e 
- Fixes microsoft#2267
- new Python Language Server rebuilds symbols in background
- remove registrations/command functionality
- add deprecation popup
- cleanup prior deprecated code
@d3r3kk d3r3kk mentioned this issue Aug 21, 2018
Merged
6 tasks
d3r3kk added a commit to d3r3kk/vscode-python that referenced this issue Aug 21, 2018
@d3r3kk
Deprecate the 'Build Workspace Symbols' command.
1ab14e7 
- Fixes microsoft#2267
- new Python Language Server rebuilds symbols in background
- remove registrations/command functionality
- add deprecation popup
- cleanup prior deprecated code
@d3r3kk
Copy link

d3r3kk commented Aug 23, 2018

We need to include this command into the list of deprecated commands.

Addendum:

...when the Python Language Server is active.

d3r3kk added a commit to d3r3kk/vscode-python that referenced this issue Aug 23, 2018
@d3r3kk
Deprecate the 'Build Workspace Symbols' command.
d9b6d3c 
- Fixes microsoft#2267
- new Python Language Server rebuilds symbols in background
- remove registrations/command functionality
- add deprecation popup
- cleanup prior deprecated code
d3r3kk added a commit to d3r3kk/vscode-python that referenced this issue Aug 24, 2018
@d3r3kk
Deprecate the 'Build Workspace Symbols' command.
b9b0ae9 
- Fixes microsoft#2267
- new Python Language Server rebuilds symbols in background
- remove registrations/command functionality
- add deprecation popup
- cleanup prior deprecated code
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@d3r3kk d3r3kk

Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Projects
None yet
Milestone
Aug 2018
Development

Successfully merging a pull request may close this issue.

Deprecate the 'Build Workspace Symbols' command when jediEnabled = false d3r3kk/vscode-python
5 participants
@brettcannon @DonJayamanne @bob-white @d3r3kk @MikhailArkhipov