Build 2018.8.0-alpha0: outline: __init__ method attributes incorrect

[derekwallace]

vscode Insiders
manually installed vscode-python 2018.8.0-alpha0

Good news is that outline shows the methods inside the class.
I think there are a number of bugs with what it displays.

There seems to be some issue with attributes.
In the following you see a number of attributes.
dCache*. these are all defined in the init method. Why are they show outside the class?
If you click on the attribute, it brings you to line 1 of the file, which is a comment.

here is the init

For this method the local variables are withing the method.

In this example its confused with "cls" which is used for a class method.

[MikhailArkhipov]

Why are they show outside the class?
See #2224
Structure is known when analysis complete. However, waiting on its completion is a non-trivial issue.

[derekwallace]

I'm not clear what point you are trying to make. Outline is much better (shows method in class) but it has bugs as per my description.

[MikhailArkhipov]

What you see is #2224. This one is basically a duplicate. Information is not available until analysis completes and it takes a while to complete. Since #2224 is still in works what you see is a partial result.

[brettcannon]

I can't reproduce the attribute issue, but I do see a problem with classmethod. With the following code:

class Spam:

    def __init__(self):
        self.answer = 42

    @classmethod
    def cls_meth(cls, arg):
        return self.answer * arg

I get the following outline (notice how cls is at the same level as Spam and all methods are attributed to cls):

[MikhailArkhipov]

@brettcannon - LSP returns information as list, not as a tree. Any nesting is some VSC 'heuristic' most probably based on names. LSP does not support https://code.visualstudio.com/updates/v1_25#_document-symbols. VS Code features do not reflect in LSP at all, LSP is not specific to VS Code and is changed on case by case basis.

@d3r3kk (great name, wrong Derek) @derekwallace - tooltip is auto-generated by vscode, we don't provide anything.

[MikhailArkhipov]

Looks like LSP 3.10 just got it https://microsoft.github.io/language-server-protocol/specification#version_3_10_0

But we may need microsoft/vscode-languageserver-node#389

[MikhailArkhipov]

microsoft/PTVS#4661