Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure CI is installing stable ptvsd releases #2432

Closed
brettcannon opened this issue Aug 22, 2018 · 1 comment · Fixed by #2433
Closed

Make sure CI is installing stable ptvsd releases #2432

brettcannon opened this issue Aug 22, 2018 · 1 comment · Fixed by #2433
Assignees
@brettcannon @d3r3kk
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
Aug 2018

Comments

@brettcannon
Copy link
Member

With ptvsd 4.1.1 now released, we should make sure we are always using the latest stable release and not any --pre releases.
@brettcannon brettcannon added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Aug 22, 2018
@brettcannon brettcannon added this to the Aug 2018 milestone Aug 22, 2018
@d3r3kk
Copy link

d3r3kk commented Aug 22, 2018

Build definitions VSCode-Python-CI and VSCode-Python-Rolling-CI are updated. I removed the --pre flag from the place I install PTVSD from in those definitions.

Do we want to pin PTVSD to a specific version?

I have left the VSCode-Python-ptvsd_master-CI build alone, it runs nightly whenever there is a change to PTVSD. It is triggered by the PTVSD-DependencyChain CI build, which triggers on a schedule every night, IFF the PTVSD:master sources have changed.

Do we want to continue to build ptvsd_master against the extension in this way?

d3r3kk added a commit to d3r3kk/vscode-python that referenced this issue Aug 22, 2018
@d3r3kk
Update travis script to use latest stable PTVSD.
4412394 
Fixes microsoft#2432
@d3r3kk d3r3kk mentioned this issue Aug 22, 2018
Merged
5 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brettcannon brettcannon

@d3r3kk d3r3kk

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
Aug 2018
Development

Successfully merging a pull request may close this issue.

Update travis script to use latest stable ptvsd d3r3kk/vscode-python
2 participants
@brettcannon @d3r3kk